Bugzilla – Attachment 188766 Details for
Bug 38306
Make automatic_renewals.pl cronjob quiet if EnhancedMessagingPreferences syspref is off
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38306: Only print EnhancedMessagingPreferences warning if run with verbose
Bug-38306-Only-print-EnhancedMessagingPreferences-.patch (text/plain), 1.79 KB, created by
Marcel de Rooy
on 2025-10-31 08:44:21 UTC
(
hide
)
Description:
Bug 38306: Only print EnhancedMessagingPreferences warning if run with verbose
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-10-31 08:44:21 UTC
Size:
1.79 KB
patch
obsolete
>From 8ad158fd33affd52b01388b738898ecdf1e156c8 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 31 Oct 2024 02:30:04 +0000 >Subject: [PATCH] Bug 38306: Only print EnhancedMessagingPreferences warning if > run with verbose >Content-Type: text/plain; charset=utf-8 > >This enhancement will amend the automatic_renewals.pl script to only print a warning about the EnhancedMessagingPreferences system preference being disabled if the script was run with verbose. > >To test: > >1. Disable EnhancedMessagingPreferences >2. Run misc/cronjobs/automatic_renewals.pl >3. Notice the warning is printed >4. Apply the patch and restart services >5. Run misc/cronjobs/automatic_renewals.pl and notice the warning is not printed >6. Run misc/cronjobs/automatic_renewals.pl --verbose and notice the warning is printed >7. Enable EnhancedMessagingPreferences >8. Run misc/cronjobs/automatic_renewals.pl and notice the warning is not printed > >Sponsored-by: Catalyst IT >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > misc/cronjobs/automatic_renewals.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index faa3cdf43d..53c906c503 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -121,7 +121,7 @@ END_WARN > # Since advance notice options are not visible in the web-interface > # unless EnhancedMessagingPreferences is on, let the user know that > # this script probably isn't going to do much >-if ( !C4::Context->preference('EnhancedMessagingPreferences') ) { >+if ( !C4::Context->preference('EnhancedMessagingPreferences') && $verbose ) { > warn <<'END_WARN'; > > The "EnhancedMessagingPreferences" syspref is off. >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38306
:
173741
|
176299
| 188766