Bugzilla – Attachment 188824 Details for
Bug 41149
Spinner/loader does not disappear when a renewal fails with AllowRenewalOnHoldOverride set to dont allow
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41149: Replace replaceWith() with empty() and append()
Bug-41149-Replace-replaceWith-with-empty-and-appen.patch (text/plain), 1.48 KB, created by
Owen Leonard
on 2025-10-31 12:56:30 UTC
(
hide
)
Description:
Bug 41149: Replace replaceWith() with empty() and append()
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-10-31 12:56:30 UTC
Size:
1.48 KB
patch
obsolete
>From 508d23e36297d7f55458e5bcad6e71a08b1b5bfa Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 30 Oct 2025 20:26:08 +0000 >Subject: [PATCH] Bug 41149: Replace replaceWith() with empty() and append() > >To test: > >1. Set AllowRenewalOnHoldOverride to 'Dont allow' >2. Set OverduesBlockRenewing to "block renewing" >3. Checkout an item and mark it as overdue. >4. Place a hold on that item to someone else >5. Now go look at the issues table for that patron/item >6. Check "Override renewal restrictions:" >7. Now a checkbox should appear in the "Renew" column, check it. >8. Click "Renew selected items" >9. After the "Renew failed: on hold" appears the spinning icon should > disappear. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 185a5488db5..f03640b7f4a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -1014,8 +1014,7 @@ $(document).ready(function () { > } > refresh_table = false; > } >- >- $(id).replaceWith(content); >+ $(id).parent().empty().append(content); > }, > error => { > console.warn("Something wrong happened: %s".format(error)); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41149
:
188706
| 188824