Bugzilla – Attachment 188827 Details for
Bug 41044
Fix argument isn't numeric in addition in Koha::Item::find_booking
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41044: Fix warning
Bug-41044-Fix-warning.patch (text/plain), 949 bytes, created by
Paul Derscheid
on 2025-10-31 14:39:45 UTC
(
hide
)
Description:
Bug 41044: Fix warning
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-10-31 14:39:45 UTC
Size:
949 bytes
patch
obsolete
>From 60ddaba8e9c6c6af04e05955de222551585d5b01 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@hypernova.fi> >Date: Fri, 17 Oct 2025 15:15:13 +0300 >Subject: [PATCH] Bug 41044: Fix warning > >To test: >1. prove t/db_dependent/Koha/Item.t >2. Observe success > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > Koha/Item.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index 05d2e97570e..d2b92c19568 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -643,7 +643,7 @@ sub find_booking { > branchcode => "*" > } > ); >- my $preparation_period = $rule ? $rule->rule_value : 0; >+ my $preparation_period = $rule && $rule->rule_value ? $rule->rule_value : 0; > $end_date = $end_date->clone->add( days => $preparation_period ); > > my $dtf = Koha::Database->new->schema->storage->datetime_parser; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41044
:
188064
|
188065
|
188447
|
188448
|
188826
| 188827