Bugzilla – Attachment 188856 Details for
Bug 39320
Create a 'landing page' for ERM
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39320: (QA follow-up): Only show 'drop widgets here' area when actively dragging
29d6227.patch (text/plain), 3.10 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-10-31 18:22:31 UTC
(
hide
)
Description:
Bug 39320: (QA follow-up): Only show 'drop widgets here' area when actively dragging
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-10-31 18:22:31 UTC
Size:
3.10 KB
patch
obsolete
>From 29d62278b965bdc2f073df8e9df94fa0f9d47a03 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 23 Oct 2025 09:56:08 +0000 >Subject: [PATCH] Bug 39320: (QA follow-up): Only show 'drop widgets here' area > when actively dragging >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../ModuleDashboard/ModuleDashboard.vue | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/ModuleDashboard.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/ModuleDashboard.vue >index 1471c2dc079..cb66718eaa0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/ModuleDashboard.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/ModuleDashboard.vue >@@ -12,7 +12,7 @@ > <div class="row"> > <div class="col-md-6 dashboard-left-col"> > <div >- v-if="selectedWidgetsLeft.length === 0" >+ v-if="selectedWidgetsLeft.length === 0 && isDragging" > class="empty-placeholder" > > > {{ $__("Drop widgets here") }} >@@ -30,6 +30,8 @@ > 'w-full', > { 'empty-drag-area': selectedWidgetsLeft.length === 0 }, > ]" >+ @start="handleDragStart" >+ @end="handleDragEnd" > > > <component > v-for="(widget, index) in selectedWidgetsLeft" >@@ -45,7 +47,7 @@ > </div> > <div class="col-md-6 dashboard-right-col"> > <div >- v-if="selectedWidgetsRight.length === 0" >+ v-if="selectedWidgetsRight.length === 0 && isDragging" > class="empty-placeholder" > > > {{ $__("Drop widgets here") }} >@@ -63,6 +65,8 @@ > 'w-full', > { 'empty-drag-area': selectedWidgetsRight.length === 0 }, > ]" >+ @start="handleDragStart" >+ @end="handleDragEnd" > > > <component > v-for="(widget, index) in selectedWidgetsRight" >@@ -93,6 +97,7 @@ export default { > const availableWidgets = props.availableWidgets; > const selectedWidgetsLeft = ref([]); > const selectedWidgetsRight = ref([]); >+ const isDragging = ref(false); > > const { setComponentDialog } = inject("mainStore"); > >@@ -251,6 +256,13 @@ export default { > { deep: true } > ); > >+ function handleDragStart() { >+ isDragging.value = true; >+ } >+ function handleDragEnd() { >+ isDragging.value = false; >+ } >+ > return { > ...props, > selectedWidgetsLeft, >@@ -260,6 +272,9 @@ export default { > removeWidget, > moveWidget, > toggleWidgetPicker, >+ handleDragEnd, >+ handleDragStart, >+ isDragging, > }; > }, > components: { >-- >2.51.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39320
:
187513
|
187514
|
187515
|
187516
|
187517
|
187518
|
187519
|
187520
|
187521
|
187522
|
187563
|
187568
|
187635
|
187636
|
187637
|
187638
|
187639
|
187640
|
187641
|
187642
|
187643
|
187644
|
187645
|
188094
|
188095
|
188096
|
188097
|
188098
|
188099
|
188100
|
188101
|
188102
|
188103
|
188104
|
188151
|
188279
|
188280
|
188281
|
188282
|
188283
|
188284
|
188285
|
188312
|
188315
|
188372
|
188375
|
188376
|
188637
|
188638
|
188639
|
188640
|
188641
|
188830
|
188831
|
188832
|
188833
|
188834
|
188835
|
188836
|
188837
|
188838
|
188839
|
188840
|
188841
|
188842
|
188843
|
188844
|
188845
|
188846
|
188847
|
188848
|
188849
|
188850
|
188851
|
188852
|
188853
|
188854
|
188855
| 188856 |
188857
|
188858
|
188859
|
188860
|
188861
|
188862
|
188863
|
188864