Bugzilla – Attachment 188859 Details for
Bug 39320
Create a 'landing page' for ERM
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39320: (QA follow-up): Use existing count method from the API client
ec8d27f.patch (text/plain), 2.84 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-10-31 18:22:39 UTC
(
hide
)
Description:
Bug 39320: (QA follow-up): Use existing count method from the API client
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-10-31 18:22:39 UTC
Size:
2.84 KB
patch
obsolete
>From ec8d27fbeb41c6cef4fc82c9f96c6483403a67f8 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 30 Oct 2025 11:50:52 +0000 >Subject: [PATCH] Bug 39320: (QA follow-up): Use existing count method from the > API client >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../ModuleDashboard/Widgets/ERMCounts.vue | 39 ++++++++++++++++--- > 1 file changed, 33 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >index c04ca367cf5..5d2f1c6350c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ModuleDashboard/Widgets/ERMCounts.vue >@@ -104,13 +104,40 @@ export default { > > async function getCounts() { > try { >- const response = await APIClient.erm.counts.get(); >+ const endpoints = [ >+ { >+ name: "agreements_count", >+ endpoint: APIClient.erm.agreements.count(), >+ }, >+ { >+ name: "licenses_count", >+ endpoint: APIClient.erm.licenses.count(), >+ }, >+ { >+ name: "eholdings_packages_count", >+ endpoint: APIClient.erm.localPackages.count(), >+ }, >+ { >+ name: "eholdings_titles_count", >+ endpoint: APIClient.erm.localTitles.count(), >+ }, >+ { >+ name: "usage_data_providers_count", >+ endpoint: APIClient.erm.usage_data_providers.count(), >+ }, >+ ]; > >- Object.keys(response.counts).forEach(key => { >- const item = countDefinitions.find(i => i.name === key); >- if (item) { >- item.count = response.counts[key]; >- } >+ endpoints.forEach(({ name, endpoint }) => { >+ endpoint >+ .then(response => { >+ const definition = countDefinitions.find(i => i.name === name); >+ if (definition) { >+ definition.count = response; >+ } >+ }) >+ .catch(error => { >+ console.error(`Error fetching ${name}:`, error); >+ }); > }); > > baseWidget.loading.value = false; >-- >2.51.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39320
:
187513
|
187514
|
187515
|
187516
|
187517
|
187518
|
187519
|
187520
|
187521
|
187522
|
187563
|
187568
|
187635
|
187636
|
187637
|
187638
|
187639
|
187640
|
187641
|
187642
|
187643
|
187644
|
187645
|
188094
|
188095
|
188096
|
188097
|
188098
|
188099
|
188100
|
188101
|
188102
|
188103
|
188104
|
188151
|
188279
|
188280
|
188281
|
188282
|
188283
|
188284
|
188285
|
188312
|
188315
|
188372
|
188375
|
188376
|
188637
|
188638
|
188639
|
188640
|
188641
|
188830
|
188831
|
188832
|
188833
|
188834
|
188835
|
188836
|
188837
|
188838
|
188839
|
188840
|
188841
|
188842
|
188843
|
188844
|
188845
|
188846
|
188847
|
188848
|
188849
|
188850
|
188851
|
188852
|
188853
|
188854
|
188855
|
188856
|
188857
|
188858
| 188859 |
188860
|
188861
|
188862
|
188863
|
188864