Bugzilla – Attachment 188884 Details for
Bug 41168
"Search the catalog by keyword" confuses some users
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41168: Remove part "by keyword" from OPAC search bar placeholder
Bug-41168-Remove-part-by-keyword-from-OPAC-search-.patch (text/plain), 4.47 KB, created by
Marcel de Rooy
on 2025-11-03 09:31:50 UTC
(
hide
)
Description:
Bug 41168: Remove part "by keyword" from OPAC search bar placeholder
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-11-03 09:31:50 UTC
Size:
4.47 KB
patch
obsolete
>From 6b698a4cdc271181d759f027c7faf1153fd66a3a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 3 Nov 2025 10:04:46 +0100 >Subject: [PATCH] Bug 41168: Remove part "by keyword" from OPAC search bar > placeholder >Content-Type: text/plain; charset=utf-8 > >Side note: The if test on ms_kw in OPAC masthead seems not to be used, >but considering that out of scope here. > >Test plan: >Check the shorter text on OPAC search bar. >Toggle SearchMyLibraryFirst and OpacAddMastheadLibraryPulldown. Refresh. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > .../opac-tmpl/bootstrap/en/includes/masthead.inc | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index c136dfeb29..2b6d4478d6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -238,9 +238,9 @@ > <label for="masthead_search" class="visually-hidden">Search the catalog by:</label> > <select name="idx" id="masthead_search" class="form-select"> > [% IF ( ms_kw ) %] >- <option selected="selected" value="" data-placeholder="[% t("Search the catalog by keyword") | html %]">Library catalog</option> >+ <option selected="selected" value="" data-placeholder="[% t("Search the catalog") | html %]">Library catalog</option> > [% ELSE %] >- <option value="" data-placeholder="[% t("Search the catalog by keyword") | html %]">Library catalog</option> >+ <option value="" data-placeholder="[% t("Search the catalog") | html %]">Library catalog</option> > [% END # /ms_kw %] > [% IF ( ms_ti ) %] > <option selected="selected" value="ti" data-placeholder="[% t("Search the catalog by title") | html %]">Title</option> >@@ -291,7 +291,7 @@ > > <div class="col order-4 order-sm-3"> > [% IF ( !Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 && mylibraryfirst ) %] >- <label for="translControl1" class="visually-hidden">Search the catalog by keyword in [% Branches.GetName( mylibraryfirst ) | html %]</label> >+ <label for="translControl1" class="visually-hidden">Search the catalog in [% Branches.GetName( mylibraryfirst ) | html %]</label> > <input > type="text" > class="transl1 form-control form-control-filtered" >@@ -301,11 +301,11 @@ > data-bs-toggle="tooltip" > data-bs-placement="top" > title="Searching in [% Branches.GetName( mylibraryfirst ) | html %] only" >- placeholder="Search the catalog by keyword" >+ placeholder="Search the catalog" > /><span id="translControl"></span> > [% ELSE %] >- <label for="translControl1" class="visually-hidden">Search the catalog by keyword</label> >- <input type="text" class="transl1 form-control" id="translControl1" name="q" value="[% ms_value | html %]" placeholder="Search the catalog by keyword" /><span id="translControl"></span> >+ <label for="translControl1" class="visually-hidden">Search the catalog</label> >+ <input type="text" class="transl1 form-control" id="translControl1" name="q" value="[% ms_value | html %]" placeholder="Search the catalog" /><span id="translControl"></span> > [% END # /ms_value %] > </div> > <!-- /.col --> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41168
: 188884