Bugzilla – Attachment 189033 Details for
Bug 41177
Breadcrumbs should have aria-disabled attribute if its the current page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41177: Add aria-disabled to breadcrumbs
Bug-41177-Add-aria-disabled-to-breadcrumbs.patch (text/plain), 12.91 KB, created by
Jake Deery
on 2025-11-04 15:48:32 UTC
(
hide
)
Description:
Bug 41177: Add aria-disabled to breadcrumbs
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2025-11-04 15:48:32 UTC
Size:
12.91 KB
patch
obsolete
>From ed36c89f9c65eaa282480415eb198982544c6594 Mon Sep 17 00:00:00 2001 >From: Jake Deery <jake.deery@openfifth.co.uk> >Date: Thu, 23 Oct 2025 12:10:30 +0100 >Subject: [PATCH] Bug 41177: Add aria-disabled to breadcrumbs > >This patch adds aria-disabled and tabindex = -1 to a breadcrumb, if it >is the current page. This aids in accesssibility, and is generally good >practice. > >== TO TEST: == >a) Visit any page on the OPAC, and inspect the breadcrumb pertinent to >the current page > *) Notice the lack of aria-disabled and tabindex on the inspected > element >== APPLY PATCH == >b) repeat step a > *) Notice how there is now an aria-disabled and tabindex = -1 > *) Notice you cannot tab on to the final breadcrumb anymore >c) Ensure other breadcrumbs are unaffected and still work as links >== SIGN OFF == >--- > koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 2 +- > .../intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 2 +- > t/mock_templates/intranet-tmpl/prog/en/modules/about.tt | 2 +- > t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt | 2 +- > 15 files changed, 15 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 0fc0fcf0401..555148d1081 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -570,7 +570,7 @@ > [% IF content.trim %] > [% IF ( bc_active ) %] > <li class="breadcrumb-item active" aria-current="page"> >- <a href="#"> [% content | $raw %] </a> >+ <a href="#" aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> > </li> > [% ELSE %] > <li class="breadcrumb-item"> [% content | $raw %] </li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >index d267032d37c..4646a0f9135 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >@@ -64,7 +64,7 @@ > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] > <li class="nav-item"> >- <a class="nav-link active currentlanguage" aria-current="page" href="#"> >+ <a class="nav-link active currentlanguage" href="#" aria-current="page" aria-disabled="true" tabindex="-1"> > [% IF ( languages_loo.native_description ) %] > [% languages_loo.native_description | html %] > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc >index bfea1f0ea65..dba3027bf11 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc >@@ -25,7 +25,7 @@ > [% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %] > [% IF ( PAGE_NUMBER.highlight ) %] > <li class="page-item active" aria-current="page"> >- <a href="#" class="page-link">[% PAGE_NUMBER.pg | html %]</a> >+ <a href="#" class="page-link" aria-disabled="true" tabindex="-1">[% PAGE_NUMBER.pg | html %]</a> > </li> > [% ELSE %] > <li class="page-item"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 7d8e3d4bdad..32cb6491357 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -26,7 +26,7 @@ > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] > [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page">About Koha</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">About Koha</a> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >index afd9a028d82..26bd1d0cd5d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >@@ -34,7 +34,7 @@ > <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> > [% END %] > [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page"> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> > <span>Record overlay rules</span> > </a> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >index 87596b65949..8f72042a2a1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >@@ -20,7 +20,7 @@ > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] > [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page"> [% tx("Error {error_number}", {error_number = errno }) | html %] </a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> [% tx("Error {error_number}", {error_number = errno }) | html %] </a> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt >index 82ab5e5ac84..0876c23f627 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/result.tt >@@ -16,7 +16,7 @@ > [% FOREACH number IN numbers %] > [% IF ( startfrom == number.startfrom ) %] > <li class="page-item active" aria-current="page"> >- <a href="#" class="page-link">[% number.number | html %]</a> >+ <a href="#" class="page-link" aria-disabled="true" tabindex="-1">[% number.number | html %]</a> > </li> > [% ELSE %] > <li class="page-item"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >index 8f8cc445353..15b1278c76c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >@@ -159,7 +159,7 @@ > [% BLOCK breadcrumb_item %] > [% IF ( bc_active ) %] > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page"> [% content | $raw %] </a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> > </li> > [% ELSE %] > <li class="breadcrumb-item"> [% content | $raw %] </li> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt >index fd4a401df91..e4c8dd333ff 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-account-pay-error.tt >@@ -27,7 +27,7 @@ > <a href="/cgi-bin/koha/opac-routing-lists.pl">[% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a> > </li> > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page">Your payment</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">Your payment</a> > </li> > </ol> > </nav> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt >index 4154af5551f..2a2a2e5e125 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-alert-subscriptions.tt >@@ -23,7 +23,7 @@ > <a href="/cgi-bin/koha/opac-user.pl">[% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a> > </li> > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page">Your alert subscriptions</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">Your alert subscriptions</a> > </li> > </ol> > </nav> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index f0ddd57f1ad..2364b24b892 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -60,7 +60,7 @@ > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <a href="#" aria-current="page">Interlibrary loan requests</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">Interlibrary loan requests</a> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt >index e5e0cff8546..3458d11b00f 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-issue-note.tt >@@ -31,7 +31,7 @@ > <a href="/cgi-bin/koha/opac-user.pl">[% INCLUDE 'patron-title.inc' patron = logged_in_user %]</a> > </li> > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page">Editing checkout note for '[% title | html %]' [% author | html %]</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">Editing checkout note for '[% title | html %]' [% author | html %]</a> > </li> > </ol> > </nav> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >index 6df0282c76b..8ee46dbc434 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt >@@ -31,7 +31,7 @@ > <a class="previous-page" href="">Catalog search for '[% q | html %]'</a> > </li> > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page">OverDrive search for '[% q | html %]'</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">OverDrive search for '[% q | html %]'</a> > </li> > </ol> > </nav> >diff --git a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt >index 692fca861f5..73f35942ffd 100644 >--- a/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt >+++ b/t/mock_templates/intranet-tmpl/prog/en/modules/about.tt >@@ -21,7 +21,7 @@ > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] > [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page">About Koha</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">About Koha</a> > [% END %] > [% END %] > [% END %] >diff --git a/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt b/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt >index 6de9b8c5151..7a7988b341a 100644 >--- a/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt >+++ b/t/mock_templates/intranet-tmpl/prog/fr-CA/modules/about.tt >@@ -21,7 +21,7 @@ > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] > [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page">About Koha</a> >+ <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">About Koha</a> > [% END %] > [% END %] > [% END %] >-- >2.50.1 (Apple Git-155)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41177
: 189033