Bugzilla – Attachment 189156 Details for
Bug 41204
OpenURL ILL no longer defaults to Standard if FreeForm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41204: Fallback to Standard earlier
Bug-41204-Fallback-to-Standard-earlier.patch (text/plain), 1.67 KB, created by
Pedro Amorim
on 2025-11-06 11:15:53 UTC
(
hide
)
Description:
Bug 41204: Fallback to Standard earlier
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-11-06 11:15:53 UTC
Size:
1.67 KB
patch
obsolete
>From b7e15eb87bb91d651fcc17ada8cf0d707631196a Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 6 Nov 2025 11:14:07 +0000 >Subject: [PATCH] Bug 41204: Fallback to Standard earlier > >The fallback to 'Standard' if 'FreeForm' needs to happen earlier in the code, before other backend checks are performed > >Test plan, before applying patch: >1) Enabled ILLModule >2) Login to OPAC and access a FreeForm URL directly: ><opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=FreeForm&op=add_form >3) Notice you get a 404. Apply patch and restart plack. >4) Repeat 2) Notice you get the 'Standard' form as expected. Create the ILL request. It's created as a 'Standard' request. >--- > opac/opac-illrequests.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-illrequests.pl b/opac/opac-illrequests.pl >index 17737e49001..55bd16a3082 100755 >--- a/opac/opac-illrequests.pl >+++ b/opac/opac-illrequests.pl >@@ -74,6 +74,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > # Are we able to actually work? > my $patron = Koha::Patrons->find($loggedinuser); > my $backends = Koha::ILL::Request::Config->new->opac_available_backends($patron); >+$params->{backend} = 'Standard' if $params->{backend} eq 'FreeForm'; > > if ( $params->{backend} && !grep { $_ eq $params->{backend} } @$backends ) { > print $query->redirect("/cgi-bin/koha/errors/404.pl"); >@@ -131,7 +132,6 @@ if ( $op eq 'list' ) { > ); > } > >- $params->{backend} = 'Standard' if $params->{backend} eq 'FreeForm'; > my $request = Koha::ILL::Request->new->load_backend( $params->{backend} ); > > # Before request creation operations - Preparation >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41204
:
189156
|
189178
|
192274