Bugzilla – Attachment 189244 Details for
Bug 39224
Move Shibboleth config from koha-conf to the DB
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39224: show warning for required fields when autocreate is enabled
Bug-39224-show-warning-for-required-fields-when-au.patch (text/plain), 2.59 KB, created by
Jacob O'Mara
on 2025-11-06 22:12:07 UTC
(
hide
)
Description:
Bug 39224: show warning for required fields when autocreate is enabled
Filename:
MIME Type:
Creator:
Jacob O'Mara
Created:
2025-11-06 22:12:07 UTC
Size:
2.59 KB
patch
obsolete
>From 3f9c4d501588d7840ff59fb9c52815462f2c102a Mon Sep 17 00:00:00 2001 >From: Jacob O'Mara <Jacob.omara@openfifth.co.uk> >Date: Thu, 6 Nov 2025 21:48:46 +0000 >Subject: [PATCH] Bug 39224: show warning for required fields when autocreate > is enabled > >--- > .../Shibboleth/ShibbolethMappingResource.vue | 34 +++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Shibboleth/ShibbolethMappingResource.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Shibboleth/ShibbolethMappingResource.vue >index 1bda24b8015..77a17d9a680 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Shibboleth/ShibbolethMappingResource.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Shibboleth/ShibbolethMappingResource.vue >@@ -1,14 +1,28 @@ > <template> >- <BaseResource :routeAction="routeAction" :instancedResource="this" /> >+ <div> >+ <div >+ v-if="routeAction === 'list' && showAutocreateWarning" >+ class="alert alert-info" >+ > >+ <i class="fa fa-info-circle"></i> >+ {{ >+ $__( >+ "When autocreate is enabled, field mappings for 'branchcode' and 'categorycode' are required. These can use either IdP attributes or default values." >+ ) >+ }} >+ </div> >+ <BaseResource :routeAction="routeAction" :instancedResource="this" /> >+ </div> > </template> > > <script> >-import { inject } from "vue"; >+import { inject, computed, onMounted, ref } from "vue"; > import BaseResource from "./../BaseResource.vue"; > import { useBaseResource } from "../../composables/base-resource.js"; > import { storeToRefs } from "pinia"; > import { APIClient } from "../../fetch/api-client.js"; > import { $__ } from "@koha-vue/i18n"; >+import { useShibbolethStore } from "../../stores/shibboleth.js"; > > export default { > name: "ShibbolethMappingResource", >@@ -156,10 +170,26 @@ export default { > } > }; > >+ const shibbolethStore = useShibbolethStore(); >+ const config = ref(null); >+ >+ const showAutocreateWarning = computed(() => { >+ return config.value?.autocreate === true; >+ }); >+ >+ onMounted(async () => { >+ try { >+ config.value = await APIClient.shibboleth.config.get(); >+ } catch (error) { >+ console.error("Failed to fetch shibboleth config:", error); >+ } >+ }); >+ > return { > ...baseResource, > tableOptions, > onFormSave, >+ showAutocreateWarning, > }; > }, > }; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39224
:
189234
|
189235
|
189236
|
189237
|
189238
|
189239
|
189240
|
189241
|
189242
|
189243
| 189244