Bugzilla – Attachment 189261 Details for
Bug 41177
Breadcrumbs should have aria-disabled attribute if its the current page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41177: (follow-up) A few minor corrections
Bug-41177-follow-up-A-few-minor-corrections.patch (text/plain), 9.94 KB, created by
Jake Deery
on 2025-11-07 09:27:40 UTC
(
hide
)
Description:
Bug 41177: (follow-up) A few minor corrections
Filename:
MIME Type:
Creator:
Jake Deery
Created:
2025-11-07 09:27:40 UTC
Size:
9.94 KB
patch
obsolete
>From 5e1e2446ecd55990beb3836e0c84c6318dd5a5fd Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 6 Nov 2025 16:22:21 +0000 >Subject: [PATCH] Bug 41177: (follow-up) A few minor corrections > >This patch makes the following corrections: > > - Remove link from breadcrumb WRAPPER items. The right markup is > generated in html_helpers.inc if you add the "bc_active = 1" to the > breadcrumb_item WRAPPER. > - Remove "href='#'" from inactive links, and adjust CSS accordingly. > The W3C validator doesn't like it when a true "aria-disabled" > attribute is on a link which has an href attribute. > >Signed-of-by: Jake Deery <jake.deery@openfifth.co.uk> >--- > .../prog/css/src/staff-global.scss | 21 +++++++------------ > .../prog/en/includes/html_helpers.inc | 2 +- > .../prog/en/includes/intranet-bottom.inc | 6 +++--- > .../intranet-tmpl/prog/en/modules/about.tt | 4 ++-- > .../en/modules/admin/marc-overlay-rules.tt | 6 ++---- > .../prog/en/modules/errors/errorpage.tt | 4 ++-- > .../opac-tmpl/bootstrap/css/src/opac.scss | 9 ++------ > .../bootstrap/en/includes/html_helpers.inc | 2 +- > .../bootstrap/en/modules/opac-illrequests.tt | 2 +- > 9 files changed, 21 insertions(+), 35 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 44c3229cf13..25b3e996972 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -3076,11 +3076,12 @@ nav { > margin-right: .3rem; > width: .8em; > } >- /*rtl:raw: >- &::before { >- transform: scaleX(-1); >+ } >+ >+ &.active { >+ a { >+ pointer-events: none; > } >- */ > } > } > >@@ -3623,18 +3624,10 @@ input.renew { > &.currentlanguage { > color: #000; > font-weight: bold; >- } >- } >- >- a { >- &.currentlanguage { >- &:link, >- &:visited { >- font-weight: bold; >- } >+ pointer-events: none; > } > >- .sublanguage-selected { >+ &.sublanguage-selected { > color: #000; > font-weight: bold; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >index 580f5c108b4..49fb48d224a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc >@@ -570,7 +570,7 @@ > [% IF content.trim %] > [% IF ( bc_active ) %] > <li class="breadcrumb-item active" aria-current="page"> >- <a href="#" aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> >+ <a aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> > </li> > [% ELSE %] > <li class="breadcrumb-item"> [% content | $raw %] </li> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >index 4646a0f9135..04766d3133d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/intranet-bottom.inc >@@ -22,7 +22,7 @@ > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.plural ) %] > <li class="nav-item dropup"> >- <a class="nav-link dropdown-toggle" id="show[% languages_loo.rfc4646_subtag | html %]" href="#" role="button" data-bs-toggle="dropdown" aria-expanded="false"> >+ <a class="nav-link dropdown-toggle" id="show[% languages_loo.rfc4646_subtag | html %]" role="button" data-bs-toggle="dropdown" aria-expanded="false"> > [% IF ( languages_loo.native_description ) %] > [% languages_loo.native_description | html %] > [% ELSE %] >@@ -41,7 +41,7 @@ > [% IF ( sublanguages_loo.enabled ) %] > [% IF ( sublanguages_loo.sublanguage_current ) %] > <li> >- <a class="nav-link currentlanguage" href="#"> >+ <a class="nav-link currentlanguage" aria-current="page"> > [% sublanguages_loo.native_description | html %] [% sublanguages_loo.script_description | html %] [% sublanguages_loo.region_description | html %] > [% sublanguages_loo.variant_description | html %] > ([% sublanguages_loo.rfc4646_subtag | html %]) >@@ -64,7 +64,7 @@ > [% IF ( languages_loo.group_enabled ) %] > [% IF ( languages_loo.current ) %] > <li class="nav-item"> >- <a class="nav-link active currentlanguage" href="#" aria-current="page" aria-disabled="true" tabindex="-1"> >+ <a class="nav-link active currentlanguage" aria-current="page" aria-disabled="true" tabindex="-1"> > [% IF ( languages_loo.native_description ) %] > [% languages_loo.native_description | html %] > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index 32cb6491357..4c10bdb9393 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -25,8 +25,8 @@ > > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] >- [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">About Koha</a> >+ [% WRAPPER breadcrumb_item bc_active = 1 %] >+ <span>About Koha</span> > [% END %] > [% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >index 26bd1d0cd5d..016d892c0be 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt >@@ -33,10 +33,8 @@ > [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> > [% END %] >- [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> >- <span>Record overlay rules</span> >- </a> >+ [% WRAPPER breadcrumb_item bc_active = 1 %] >+ <span>Record overlay rules</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >index 8f72042a2a1..6028c1c0f65 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt >@@ -19,8 +19,8 @@ > > [% WRAPPER 'sub-header.inc' %] > [% WRAPPER breadcrumbs %] >- [% WRAPPER breadcrumb_item %] >- <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> [% tx("Error {error_number}", {error_number = errno }) | html %] </a> >+ [% WRAPPER breadcrumb_item bc_active = 1 %] >+ [% tx("Error {error_number}", {error_number = errno }) | html %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >index d407c017594..de0706245db 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss >@@ -640,13 +640,8 @@ th { > } > > &.active { >- a:link, >- a:visited, >- a:hover, >- a:active { >- color: #666; >- cursor: text; >- text-decoration: none; >+ a { >+ pointer-events: none; > } > } > } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >index 15b1278c76c..8e747ede4e2 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc >@@ -159,7 +159,7 @@ > [% BLOCK breadcrumb_item %] > [% IF ( bc_active ) %] > <li class="breadcrumb-item active"> >- <a href="#" aria-current="page" aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> >+ <a aria-current="page" aria-disabled="true" tabindex="-1"> [% content | $raw %] </a> > </li> > [% ELSE %] > <li class="breadcrumb-item"> [% content | $raw %] </li> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 2364b24b892..cd17cee4906 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -60,7 +60,7 @@ > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- <a href="#" aria-current="page" aria-disabled="true" tabindex="-1">Interlibrary loan requests</a> >+ <span>Interlibrary loan requests</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >-- >2.50.1 (Apple Git-155)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41177
:
189033
|
189188
|
189189
|
189261
|
189262
|
189651
|
189652
|
189653
|
189931
|
189932