Bugzilla – Attachment 18940 Details for
Bug 10463
Quote of the day feature not selecting random quotes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10463 - Quote of the day feature not selecting random quotes
Bug-10463---Quote-of-the-day-feature-not-selecting.patch (text/plain), 2.15 KB, created by
Kyle M Hall (khall)
on 2013-06-13 13:48:48 UTC
(
hide
)
Description:
Bug 10463 - Quote of the day feature not selecting random quotes
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-06-13 13:48:48 UTC
Size:
2.15 KB
patch
obsolete
>From 6d6c07ce9a09ea823d37b49ffe993dc1fe2d148c Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 13 Jun 2013 09:46:43 -0400 >Subject: [PATCH] Bug 10463 - Quote of the day feature not selecting random quotes > >When the Quote of the Day tool selects a new new quote, it updates the >timestamp and does not take the timezone into account. Thus the time is >set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 > 09:33:48). It then repeats the same quote every day. > >To replicate: > >set Administration >> System preferences >> OPAC preferences >> Features >>> QuoteOfTheDay to Enable > >In Home >> Tools >> Quote Editor, add several quotes. > >In the opac, refresh the home page. You should get a quote of the day at >the top. > >mysql> select * from quotes; > >note the timestamp of the quote selected by the tool. It will not match >the date on the machine. > >If you change the date to the previous date and refresh the opac, the >tool wlill select another quote, which will not change unless forced. > >Test Plan: >1) Remove all your quotes and import a fresh set >2) Enable the quote of the day and view the opac >3) Look at your quotes table and note the timestamp is incorrect >4) Repeat steps 1 and 2 >5) Look at your quotes table and note the timestamp is now correct >--- > C4/Koha.pm | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 9976995..e40efc9 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -25,8 +25,8 @@ use strict; > > use C4::Context; > use C4::Branch qw(GetBranchesCount); >+use Koha::DateUtils qw(dt_from_string); > use Memoize; >-use DateTime; > use DateTime::Format::MySQL; > use autouse 'Data::Dumper' => qw(Dumper); > >@@ -1478,7 +1478,10 @@ sub GetDailyQuote { > # update the timestamp for that quote > $query = 'UPDATE quotes SET timestamp = ? WHERE id = ?'; > $sth = C4::Context->dbh->prepare($query); >- $sth->execute(DateTime::Format::MySQL->format_datetime(DateTime->now), $quote->{'id'}); >+ $sth->execute( >+ DateTime::Format::MySQL->format_datetime( dt_from_string() ), >+ $quote->{'id'} >+ ); > } > return $quote; > } >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10463
:
18940
|
19711
|
19947