Bugzilla – Attachment 189463 Details for
Bug 31391
Staff-side recalls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31391: (follow-up) Only skip displaying recalls in messaging preference is UseRecalls syspref is off
Bug-31391-follow-up-Only-skip-displaying-recalls-i.patch (text/plain), 2.35 KB, created by
Alex Buckley
on 2025-11-10 23:18:05 UTC
(
hide
)
Description:
Bug 31391: (follow-up) Only skip displaying recalls in messaging preference is UseRecalls syspref is off
Filename:
MIME Type:
Creator:
Alex Buckley
Created:
2025-11-10 23:18:05 UTC
Size:
2.35 KB
patch
obsolete
>From 7751a6461c8fc3d3bfbcd9b7731dad093ade4f62 Mon Sep 17 00:00:00 2001 >From: Alex Buckley <alexbuckley@catalyst.net.nz> >Date: Mon, 10 Nov 2025 04:25:35 +0000 >Subject: [PATCH] Bug 31391: (follow-up) Only skip displaying recalls in > messaging preference is UseRecalls syspref is off > >This patch includes a fix to display the two recalls notices (PICKUP_RECALLED_ITEM and RETURN_RECALLED_ITEM) added to the members messaging preferences table by bug 23781 > >Now those two recalls notices are always displayed in the messaging preference form, when UseRecalls is set to: opac, staff or opac_and_staff > >Test plan: >1. Set the UseRecalls system preference to opac, staff or opac_and_staff >2. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO NOT appear in the Member (User) messaging preferences on a patron account or when editing a category >3. Apply this patch >4. Confirm that the 'Return recalled item' and 'Recall awaiting pickup' rows DO now appear in the Member (User) messaging preferences on a patron account or when editing a category > >Sponsored-by: Auckland University of Technology >--- > .../prog/en/includes/messaging-preference-form.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >index 3a16fd9b897..9ce2c850d2f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >@@ -24,7 +24,7 @@ > [% NEXT IF !Koha.Preference('MembershipExpiryDaysNotice') && messaging_preference.Patron_Expiry %] > [% NEXT IF messaging_preference.Patron_Expiry && (category.enforce_expiry_notice || patron.category.enforce_expiry_notice) %] > [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %] >- [% NEXT IF Koha.Preference('UseRecalls') != "off" && messaging_preference.message_name.match('^Recall_') %] >+ [% NEXT IF Koha.Preference('UseRecalls') == "off" && messaging_preference.message_name.match('^Recall_') %] > <tr id="[% messaging_preference.message_name _ "_message" | lower | html %]"> > <td > >[% IF ( messaging_preference.Item_Due ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31391
:
139442
|
139443
|
139444
|
139446
|
139642
|
139643
|
139644
|
139645
|
141474
|
142594
|
143155
|
144104
|
144105
|
144131
|
144132
|
144133
|
144134
|
144135
|
144136
|
147581
|
147582
|
150485
|
150486
|
150487
|
150488
|
150489
|
150490
|
150491
|
156995
|
156996
|
156997
|
156998
|
156999
|
157000
|
157001
|
158691
|
158692
|
158693
|
158694
|
158695
|
158825
|
158826
|
158827
|
158828
|
158829
|
158830
|
158831
|
158832
|
172166
|
172167
|
172168
|
172169
|
172170
|
172171
|
172172
|
172173
|
172174
|
172175
|
173839
|
173840
|
173841
|
173842
|
173843
|
173844
|
173845
|
173846
|
173847
|
174396
|
174822
|
174823
|
174824
|
174825
|
174826
|
174827
|
174828
|
174829
|
174830
|
174831
|
177901
|
177902
|
177903
|
177904
|
177905
|
177906
|
177907
|
177908
|
177909
|
177910
|
185180
|
185181
|
185182
|
185183
|
185184
|
185185
|
185186
|
185187
|
185188
|
185189
|
185190
|
189452
|
189453
|
189454
|
189455
|
189456
|
189457
|
189458
|
189459
|
189460
|
189461
|
189462
| 189463 |
189473