Bugzilla – Attachment 189475 Details for
Bug 41078
Improve handling of multiple covers on shelves/lists results in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41078: (follow-up) Use __() instead of _()
Bug-41078-follow-up-Use--instead-of-.patch (text/plain), 4.47 KB, created by
Paul Derscheid
on 2025-11-11 07:01:00 UTC
(
hide
)
Description:
Bug 41078: (follow-up) Use __() instead of _()
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-11-11 07:01:00 UTC
Size:
4.47 KB
patch
obsolete
>From edf1278a6daef45b3a6938d113b6ef4b35fce891 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 7 Nov 2025 13:38:47 +0000 >Subject: [PATCH] Bug 41078: (follow-up) Use __() instead of _() > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > .../opac-tmpl/bootstrap/js/cover_images.js | 24 ++++++++++--------- > 1 file changed, 13 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/cover_images.js b/koha-tmpl/opac-tmpl/bootstrap/js/cover_images.js >index 841612b9896..ceb9174df24 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/cover_images.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/cover_images.js >@@ -22,7 +22,7 @@ function verify_cover_images() { > div.remove(); > } else { > lightbox_descriptions.push( >- _( >+ __( > "Amazon cover image (<a href='%s'>see the original image</a>)" > ).format($(img).data("link")) > ); >@@ -36,21 +36,23 @@ function verify_cover_images() { > // Remove the container > div.remove(); > } else { >- lightbox_descriptions.push(_("Custom cover image")); >+ lightbox_descriptions.push( >+ __("Custom cover image") >+ ); > } > } else if (div.hasClass("syndetics-coverimg")) { >- lightbox_descriptions.push(_("Image from Syndetics")); >+ lightbox_descriptions.push(__("Image from Syndetics")); > } else if (div.hasClass("googlejacket-coverimg")) { > if (img.naturalHeight) { > lightbox_descriptions.push( >- _( >+ __( > "Image from Google Books (<a href='%s'>see the original image</a>)" > ).format($(img).data("link")) > ); > } > } else if (div.hasClass("openlibrary-coverimg")) { > lightbox_descriptions.push( >- _( >+ __( > "Image from OpenLibrary (<a href='%s'>see the original image</a>)" > ).format($(img).data("link")) > ); >@@ -59,13 +61,13 @@ function verify_cover_images() { > var coce_description; > let src = $(img).attr("src"); > if (src.indexOf("amazon.com") >= 0) { >- coce_description = _("Coce image from Amazon.com"); >+ coce_description = __("Coce image from Amazon.com"); > } else if (src.indexOf("google.com") >= 0) { >- coce_description = _( >+ coce_description = __( > "Coce image from Google Books" > ); > } else if (src.indexOf("openlibrary.org") >= 0) { >- coce_description = _( >+ coce_description = __( > "Coce image from Open Library" > ); > } >@@ -73,13 +75,13 @@ function verify_cover_images() { > lightbox_descriptions.push(coce_description); > } else if (div.hasClass("bakertaylor-coverimg")) { > lightbox_descriptions.push( >- _("Image from Baker & Taylor") >+ __("Image from Baker & Taylor") > ); > } else if (div.hasClass("cover-image local-coverimg")) { >- lightbox_descriptions.push(_("Local cover image")); >+ lightbox_descriptions.push(__("Local cover image")); > } else { > lightbox_descriptions.push( >- _("Cover image source unknown") >+ __("Cover image source unknown") > ); > } > } else { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41078
:
189142
|
189246
|
189319
|
189320
|
189474
| 189475