Bugzilla – Attachment 18948 Details for
Bug 10218
Add individual CSS classes for bibliographic information on OPAC results and detail pages (UNIMARC)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Bug 10218 : Followup for UNIMARC
0004-new.patch (text/plain), 13.37 KB, created by
Mathieu Saby
on 2013-06-13 18:34:23 UTC
(
hide
)
Description:
[PATCH] Bug 10218 : Followup for UNIMARC
Filename:
MIME Type:
Creator:
Mathieu Saby
Created:
2013-06-13 18:34:23 UTC
Size:
13.37 KB
patch
obsolete
>From b615ea932b53149cd9f3fc769542a3a854080df1 Mon Sep 17 00:00:00 2001 >From: Mathieu Saby <mathieu.saby@univ-rennes2.fr> >Date: Thu, 13 Jun 2013 20:22:51 +0200 >Subject: [PATCH] Bug 10218 : Followup for UNIMARC > >Follow-up for UNIMARC XSLT Display >This patch adds class to span markup in list and detail display. >XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma > >To test, apply the patch on a Koha instance with UNIMARC records, and >- activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay >- make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" >- view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. >--- > .../prog/en/xslt/UNIMARCslim2OPACDetail.xsl | 43 +++++++++++++------- > .../prog/en/xslt/UNIMARCslim2OPACResults.xsl | 5 ++- > .../opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl | 18 ++++---- > 3 files changed, 43 insertions(+), 23 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >index cb365d9..700b62f 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl >@@ -69,61 +69,72 @@ > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">454</xsl:with-param> > <xsl:with-param name="label">Translation of</xsl:with-param> >+ <xsl:with-param name="spanclass">original_title</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">461</xsl:with-param> > <xsl:with-param name="label">Set Level</xsl:with-param> >+ <xsl:with-param name="spanclass">set_level</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">464</xsl:with-param> > <xsl:with-param name="label">Piece-Analytic Level</xsl:with-param> >+ <xsl:with-param name="spanclass">piece_analytic_level</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">700</xsl:with-param> > <xsl:with-param name="label">Main Author</xsl:with-param> >+ <xsl:with-param name="spanclass">main_author</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">710</xsl:with-param> > <xsl:with-param name="label">Corporate Author (Main)</xsl:with-param> >+ <xsl:with-param name="spanclass">corporate_main_author</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">701</xsl:with-param> > <xsl:with-param name="label">Coauthor</xsl:with-param> >+ <xsl:with-param name="spanclass">coauthor</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">702</xsl:with-param> > <xsl:with-param name="label">Secondary Author</xsl:with-param> >+ <xsl:with-param name="spanclass">secondary_author</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">711</xsl:with-param> > <xsl:with-param name="label">Corporate Author (Coauthor)</xsl:with-param> >+ <xsl:with-param name="spanclass">corporate_coauthor</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_7xx"> > <xsl:with-param name="tag">712</xsl:with-param> > <xsl:with-param name="label">Corporate Author (Secondary)</xsl:with-param> >+ <xsl:with-param name="spanclass">corporate_secondary_author</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">500</xsl:with-param> > <xsl:with-param name="label">Uniform Title</xsl:with-param> >+ <xsl:with-param name="spanclass">uniform_title</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">503</xsl:with-param> > <xsl:with-param name="label">Uniform Conventional Heading</xsl:with-param> >+ <xsl:with-param name="spanclass">uniform_conventional_heading</xsl:with-param> > </xsl:call-template> > > <xsl:if test="marc:datafield[@tag=101]"> >- <span class="results_summary"> >- <span class="label">Language:</span> >+ <span class="results_summary language"> >+ <span class="label">Language: </span> > <xsl:for-each select="marc:datafield[@tag=101]"> > <xsl:for-each select="marc:subfield"> > <xsl:choose> >@@ -152,7 +163,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=102]"> >- <span class="results_summary"> >+ <span class="results_summary country"> > <span class="label">Country: </span> > <xsl:for-each select="marc:datafield[@tag=102]"> > <xsl:for-each select="marc:subfield"> >@@ -172,6 +183,7 @@ > <xsl:call-template name="tag_comma"> > <xsl:with-param name="tag">205</xsl:with-param> > <xsl:with-param name="label">Edition Statement</xsl:with-param> >+ <xsl:with-param name="spanclass">edition</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_210" /> >@@ -179,7 +191,7 @@ > <xsl:call-template name="tag_215" /> > > <xsl:if test="marc:datafield[@tag=010]/marc:subfield[@code='a']"> >- <span class="results_summary"><span class="label">ISBN: </span> >+ <span class="results_summary isbn"><span class="label">ISBN: </span> > <xsl:for-each select="marc:datafield[@tag=010]"> > <xsl:variable name="isbn" select="marc:subfield[@code='a']"/> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -196,7 +208,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=011]"> >- <span class="results_summary"> >+ <span class="results_summary issn"> > <span class="label">ISSN: </span> > <xsl:for-each select="marc:datafield[@tag=011]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -215,10 +227,11 @@ > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">225</xsl:with-param> > <xsl:with-param name="label">Series</xsl:with-param> >+ <xsl:with-param name="spanclass">series</xsl:with-param> > </xsl:call-template> > > <xsl:if test="marc:datafield[@tag=676]"> >- <span class="results_summary"> >+ <span class="results_summary dewey"> > <span class="label">Dewey: </span> > <xsl:for-each select="marc:datafield[@tag=676]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -238,7 +251,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=686]"> >- <span class="results_summary"> >+ <span class="results_summary classification"> > <span class="label">Classification: </span> > <xsl:for-each select="marc:datafield[@tag=686]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -256,7 +269,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=327]"> >- <span class="results_summary"> >+ <span class="results_summary contents"> > <span class="label">Contents note: </span> > <xsl:for-each select="marc:datafield[@tag=327]"> > <xsl:call-template name="chopPunctuation"> >@@ -273,7 +286,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=330]"> >- <span class="results_summary"> >+ <span class="results_summary abstract"> > <span class="label">Abstract: </span> > <xsl:for-each select="marc:datafield[@tag=330]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -290,7 +303,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=317]"> >- <span class="results_summary"> >+ <span class="results_summary provenance"> > <span class="label">Provenance note: </span> > <xsl:for-each select="marc:datafield[@tag=317]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -299,7 +312,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=320]"> >- <span class="results_summary"> >+ <span class="results_summary bibliography"> > <span class="label">Bibliography: </span> > <xsl:for-each select="marc:datafield[@tag=320]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -309,7 +322,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=328]"> >- <span class="results_summary"> >+ <span class="results_summary thesis"> > <span class="label">Thesis: </span> > <xsl:for-each select="marc:datafield[@tag=328]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -319,7 +332,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=333]"> >- <span class="results_summary"> >+ <span class="results_summary audience"> > <span class="label">Audience: </span> > <xsl:for-each select="marc:datafield[@tag=333]"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -329,7 +342,7 @@ > </xsl:if> > > <xsl:if test="marc:datafield[@tag=955]"> >- <span class="results_summary"> >+ <span class="results_summary sudoc_serial_history"> > <span class="label">SUDOC serial history: </span> > <xsl:for-each select="marc:datafield[@tag=955]"> > <xsl:value-of select="marc:subfield[@code='9']"/>: >@@ -390,7 +403,7 @@ > </xsl:call-template> > > <xsl:if test="marc:datafield[@tag=856]"> >- <span class="results_summary"> >+ <span class="results_summary online_resources"> > <span class="label">Online Resources:</span> > <xsl:for-each select="marc:datafield[@tag=856]"> > <a> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl >index a086d31..c4ae3c1 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACResults.xsl >@@ -79,23 +79,26 @@ > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">454</xsl:with-param> > <xsl:with-param name="label">Translation of</xsl:with-param> >+ <xsl:with-param name="spanclass">original_title</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">461</xsl:with-param> > <xsl:with-param name="label">Set Level</xsl:with-param> >+ <xsl:with-param name="spanclass">set_level</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_title"> > <xsl:with-param name="tag">464</xsl:with-param> > <xsl:with-param name="label">Piece-Analytic Level</xsl:with-param> >+ <xsl:with-param name="spanclass">piece_analytic_level</xsl:with-param> > </xsl:call-template> > > <xsl:call-template name="tag_210" /> > > <xsl:call-template name="tag_215" /> > >- <span class="results_summary"> >+ <span class="results_summary availability"> > <span class="label">Availability: </span> > <xsl:choose> > <xsl:when test="marc:datafield[@tag=856]"> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >index 91d9b3d..821f02f 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl >@@ -83,8 +83,9 @@ > <xsl:template name="tag_title"> > <xsl:param name="tag" /> > <xsl:param name="label" /> >+ <xsl:param name="spanclass" /> > <xsl:if test="marc:datafield[@tag=$tag]"> >- <span class="results_summary"> >+ <span class="results_summary {$spanclass}"> > <span class="label"> > <xsl:value-of select="$label"/>: </span> > <xsl:for-each select="marc:datafield[@tag=$tag]"> >@@ -137,8 +138,9 @@ > <xsl:template name="tag_comma"> > <xsl:param name="tag" /> > <xsl:param name="label" /> >+ <xsl:param name="spanclass" /> > <xsl:if test="marc:datafield[@tag=$tag]"> >- <span class="results_summary"> >+ <span class="results_summary {$spanclass}"> > <span class="label"> > <xsl:value-of select="$label"/>: </span> > <xsl:for-each select="marc:datafield[@tag=$tag]"> >@@ -158,8 +160,8 @@ > </xsl:template> > > <xsl:template name="tag_210"> >- <span class="results_summary"> >- <span class="label">Publication:</span> >+ <span class="results_summary publication"> >+ <span class="label">Publication: </span> > <xsl:for-each select="marc:datafield[@tag=210]"> > <span> > <xsl:call-template name="addClassRtl" /> >@@ -189,7 +191,7 @@ > > <xsl:template name="tag_215"> > <xsl:for-each select="marc:datafield[@tag=215]"> >- <span class="results_summary"> >+ <span class="results_summary description"> > <span class="label">Description: </span> > <xsl:if test="marc:subfield[@code='a']"> > <xsl:value-of select="marc:subfield[@code='a']"/> >@@ -293,8 +295,9 @@ > <xsl:template name="tag_subject"> > <xsl:param name="tag" /> > <xsl:param name="label" /> >+ <xsl:param name="spanclass" /> > <xsl:if test="marc:datafield[@tag=$tag]"> >- <span class="results_summary"> >+ <span class="results_summary subjects {$spanclass}"> > <span class="label"> > <xsl:value-of select="$label"/> > <xsl:text>: </xsl:text> >@@ -312,8 +315,9 @@ > <xsl:template name="tag_7xx"> > <xsl:param name="tag" /> > <xsl:param name="label" /> >+ <xsl:param name="spanclass" /> > <xsl:if test="marc:datafield[@tag=$tag]"> >- <span class="results_summary"> >+ <span class="results_summary author {$spanclass}"> > <span class="label"> > <xsl:value-of select="$label" /> > <xsl:text>: </xsl:text> >-- >1.7.9.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10218
:
18028
|
18119
|
18295
|
18402
|
18948
|
20678
|
20679
|
20861