Bugzilla – Attachment 189506 Details for
Bug 40105
Patrons cannot add notes when creating an ILL
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40105: (QA follow-up): Have a 'additional information' section
Bug-40105-QA-follow-up-Have-a-additional-informati.patch (text/plain), 6.73 KB, created by
Pedro Amorim
on 2025-11-12 11:15:25 UTC
(
hide
)
Description:
Bug 40105: (QA follow-up): Have a 'additional information' section
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-11-12 11:15:25 UTC
Size:
6.73 KB
patch
obsolete
>From abc4ceb4ad19ba979299b5b8ddc6590fae41fcc6 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 12 Nov 2025 11:08:07 +0000 >Subject: [PATCH] Bug 40105: (QA follow-up): Have a 'additional information' > section > >This will encompass the 'Notes' field plus custom fields. >--- > .../includes/ill/backends/Standard/create.inc | 7 ++- > .../Standard/shared/custom_fields.inc | 51 +++++++++---------- > .../ill/backends/Standard/shared/notes.inc | 11 ++-- > .../ill/backends/Standard/shared/shared.js | 1 + > 4 files changed, 36 insertions(+), 34 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >index 90bd211b888..1f94b8046eb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/create.inc >@@ -103,8 +103,11 @@ > [% IF type %] > [% INCLUDE "ill/backends/Standard/shared/forms/${type}.inc" %] > [% END %] >- [% INCLUDE "ill/backends/Standard/shared/notes.inc" %] >- [% INCLUDE "ill/backends/Standard/shared/custom_fields.inc" %] >+ <legend>Additional information</legend> >+ <fieldset class="rows"> >+ [% INCLUDE "ill/backends/Standard/shared/notes.inc" %] >+ [% INCLUDE "ill/backends/Standard/shared/custom_fields.inc" %] >+ </fieldset> > [% IF whole.value.other.type && unauthenticated_ill && !logged_in_user %] > <fieldset class="rows" id="illrequest_captcha"> > <legend>Verification</legend> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/custom_fields.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/custom_fields.inc >index e49b3832632..0cea3b8279c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/custom_fields.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/custom_fields.inc >@@ -1,34 +1,31 @@ >-<fieldset class="rows"> >- <legend>Custom fields</legend> >- <ol id="standard-fields"> >- [% keys = whole.value.other.custom_key.split('\0') %] >- [% values = whole.value.other.custom_value.split('\0') %] >- [% i = 0 %] >- [% FOREACH key IN keys %] >- <li class="form-horizontal"> >- [% IF opac %] >- <input type="text" placeholder="key" class="form-control input-fluid custom-field-input custom-name" name="custom_key" value="[% key | html %]" /> >- <input type="text" placeholder="value" class="form-control input-fluid custom-field-input" name="custom_value" id="custom-value" value="[% values.$i | html %]" /> >- [% ELSE %] >- <input type="text" placeholder="key" class="custom-name" name="custom_key" value="[% key | html %]" /> >- <input type="text" placeholder="value" name="custom_value" id="custom-value" value="[% values.$i | html %]" /> >- [% END %] >- <button value="[% i | html %]" name="custom_delete" type="submit" class="btn btn-danger btn-sm delete-new-field"> <span class="fa fa-trash"></span> Delete </button> >- </li> >- [% i = i + 1 %] >- [% END %] >- </ol> >- <div id="custom-warning" style="display:none;margin:1em;" class="error required"></div> >- <button type="button" id="add-new-fields" class="btn btn-default"> >- <span class="fa fa-plus"></span> >- Add new field >- </button> >-</fieldset> >+<ol id="standard-fields"> >+ [% keys = whole.value.other.custom_key.split('\0') %] >+ [% values = whole.value.other.custom_value.split('\0') %] >+ [% i = 0 %] >+ [% FOREACH key IN keys %] >+ <li class="form-horizontal"> >+ <label> </label> >+ [% IF opac %] >+ <input type="text" placeholder="key" class="form-control input-fluid custom-field-input custom-name" name="custom_key" value="[% key | html %]" /> >+ <input type="text" placeholder="value" class="form-control input-fluid custom-field-input" name="custom_value" id="custom-value" value="[% values.$i | html %]" /> >+ [% ELSE %] >+ <input type="text" placeholder="key" class="custom-name" name="custom_key" value="[% key | html %]" /> >+ <input type="text" placeholder="value" name="custom_value" id="custom-value" value="[% values.$i | html %]" /> >+ [% END %] >+ <button value="[% i | html %]" name="custom_delete" type="submit" class="btn btn-danger btn-sm delete-new-field"> <span class="fa fa-trash"></span> Delete </button> >+ </li> >+ [% i = i + 1 %] >+ [% END %] >+</ol> >+<div id="custom-warning" style="display:none;margin:1em;" class="error required"></div> >+<button type="button" id="add-new-fields" class="btn btn-default"> >+ <span class="fa fa-plus"></span> >+ Add new field >+</button> > > <style> > .custom-field-input { > width: 25%; > display: inline-block; >- margin-left: 0.5em; > } > </style> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc >index 5ec10d45799..4e49ea3ecf3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/notes.inc >@@ -1,5 +1,6 @@ >-<fieldset class="rows" id="ill-standard-notes"> >- <legend>Notes</legend> >- <label class="sr-only" for="notesopac">Notes:</label> >- <textarea name="notesopac" id="notesopac" class="form-control input-fluid">[% whole.value.other.notesopac | html %]</textarea> >-</fieldset> >+<ol id="standard-opac-notes"> >+ <li> >+ <label for="notesopac">Notes:</label> >+ <textarea name="notesopac" id="notesopac" class="form-control input-fluid">[% whole.value.other.notesopac | html %]</textarea> >+ </li> >+</ol> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/shared.js b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/shared.js >index 493a4146c64..358e462c60e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/shared.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/shared.js >@@ -3,6 +3,7 @@ document.addEventListener("DOMContentLoaded", function () { > e.preventDefault(); > var row = > '<li class="form-horizontal">' + >+ "<label> </label>" + > '<input type="text" class="custom-name ' + > "form-control input-fluid custom-field-input" + > '" name="custom_key" placeholder="' + >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40105
:
184523
|
185354
|
185942
|
189506
|
189507
|
189515
|
189516