Bugzilla – Attachment 189533 Details for
Bug 33647
Display borrowers.lastseen in patron record
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked
Bug-33647-follow-up-Wording-update--only-show-last.patch (text/plain), 2.78 KB, created by
Martin Renvoize (ashimema)
on 2025-11-13 08:00:48 UTC
(
hide
)
Description:
Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-11-13 08:00:48 UTC
Size:
2.78 KB
patch
obsolete
>From 15868574ead4e80c0f0b32a7e7b521f9ddbe0b26 Mon Sep 17 00:00:00 2001 >From: CJ Lynce <cj.lynce@westlakelibrary.org> >Date: Wed, 1 Oct 2025 18:55:51 +0000 >Subject: [PATCH] Bug 33647: (follow-up) Wording update & only show lastseen if > activity is tracked > >This follow-up implements these suggestions: >A. Uses 'not recorded' instead of never when there is no date. >B. Only shows lastseen if syspref TrackLastPatronActivityTriggers has at least one trigger. > >To test: > >1. Apply patch >2. Ensure syspref TrackLastPatronActivityTriggers has no triggers set. >3. Check patron record top left corner to verify lastseen is not shown. >4. Change system TrackLastPatronActivityTriggers to trigger on Checking out an item. >5. Recheck patron record top left corner to verify lastseen says "not recorded". >6. Check out a book to patron >7. Recheck patron record top left corner to verify there is a date and time shown. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > .../prog/en/includes/circ-menu.inc | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >index e1f2358944c..6f9909c0c46 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc >@@ -153,14 +153,16 @@ > <li> > <span class="patronupdatedon">Updated on: [% patron.updated_on | $KohaDates with_hours => 1 %]</span> > </li> >- [% IF ( patron.lastseen ) %] >- <li> >- <span class="patronlastseenon">Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %]</span> >- </li> >- [% ELSE %] >- <li> >- <span class="patronlastseenon">Last seen on: Never</span> >- </li> >+ [% IF Koha.Preference('TrackLastPatronActivityTriggers') %] >+ [% IF ( patron.lastseen ) %] >+ <li> >+ <span class="patronlastseenon">Last seen on: [% patron.lastseen | $KohaDates with_hours => 1 %]</span> >+ </li> >+ [% ELSE %] >+ <li> >+ <span class="patronlastseenon">Last seen on: not recorded</span> >+ </li> >+ [% END %] > [% END %] > [% IF patron.account_locked %] > [% IF patron.login_attempts < 0 %] >-- >2.51.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33647
:
185382
|
185402
|
185403
|
185535
|
187223
|
188925
|
189530
|
189531
|
189532
| 189533