Attachment 18965 Details for Bug 7639 – [Signed off] Bug 7639 - system preference to forgive fines on lost items - QA Followup

[patch] [Signed off] Bug 7639 - system preference to forgive fines on lost items - QA Followup

Signed-off-Bug-7639---system-preference-to-forgive.patch (text/plain), 1.55 KB, created by Melia Meggs on 2013-06-13 21:36:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Melia Meggs

Created: 2013-06-13 21:36:38 UTC

Size: 1.55 KB

patch

obsolete

>From 3696e7b7c42f9744bcf3278efc07fa051262cbc5 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 23 Oct 2012 08:03:16 -0400
>Subject: [PATCH] [Signed off] Bug 7639 - system preference to forgive fines on lost items - QA Followup
>
>Test Plan:
> 1) Apply the patch
> 2) Run updatedatabase.pl
> 3) Set WhenLostForgiveFine to Forgive & WhenLostChargeReplacementFee to Charge
> 4) Issue an item to a borrower, then set to lost from catalogue/moredetail.pl
> 5) Observe the replacement fee has been charged
> 6) Return the item
> 7) Observe the charged fee has been forgiven
> 8) Set WhenLostForgiveFine to Don't Forgive
> 9) Repeat 4-6
>10) Observe the charged fee has not been forgiven
>11) Set WhenLostChargeReplacementFee to Don't Charge
>12) Repeat 4
>13) Observe that a fee was not charged
>
>Signed-off-by: Alex Hatley <alexh@cctexas.com>
>---
> cataloguing/additem.pl |    5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 8985bc6..488f3a6 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -608,7 +608,10 @@ if ($op eq "additem") {
>     }
>   my $item = GetItem( $itemnumber );
>     my $olditemlost =  $item->{'itemlost'};
>-    my $newitemlost = $itemtosave->subfield('952','1');
>+
>+   my ($lost_tag,$lost_subfield) = GetMarcFromKohaField("items.itemlost",'');
>+
>+   my $newitemlost = $itemtosave->subfield( $lost_tag, $lost_subfield );
>     if (($olditemlost eq '0' or $olditemlost eq '' ) and $newitemlost ge '1'){
>   LostItem($itemnumber,'MARK RETURNED');
>     }
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7639: 9281 | 9282 | 9436 | 10662 | 10663 | 13006 | 13007 | 14961 | 14962 | 15088 | 15089 | 16593 | 16607 | 16608 | 16609 | 16729 | 16730 | 16731 | 18929 | 18930 | 18932 | 18964 | 18965 | 18966 | 19654 | 19655 | 19656 | 19657 | 20436 | 20437 | 20438 | 20439 | 20456 | 20487