Bugzilla – Attachment 189684 Details for
Bug 41211
Cannot cancel patron holds in some cases
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41211: Deal with findborrower in holds_table_patron_page function
7cf11b5.patch (text/plain), 2.01 KB, created by
Martin Renvoize (ashimema)
on 2025-11-18 19:22:11 UTC
(
hide
)
Description:
Bug 41211: Deal with findborrower in holds_table_patron_page function
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-11-18 19:22:11 UTC
Size:
2.01 KB
patch
obsolete
>From 7cf11b55a3273d2ac052e4aac9c2842d009ef527 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 6 Nov 2025 21:25:58 +0000 >Subject: [PATCH] Bug 41211: Deal with findborrower in holds_table_patron_page > function > >To test: > >1. Find a patron, take note of their cardnumber, and place some holds for that patron. I use Ronnie Ballard ( 23529000139858 ) in k-t-d. >2. Scan the patrons cardnumber to bring you directly to their record. The URL for me is KOHA/cgi-bin/koha/circ/circulation.pl?findborrower=23529000139858 >3. Go to the patron's "Hold" tab, check at least 1 hold and click "Cancel selected". >4. Nothing happens. Console error: Uncaught ReferenceError: biblionumbers is not defined >5. Try using the red trash can icon to delete the hold. A modal pops up, click "Confirm cancellation". >6. You are redirected to KOHA/cgi-bin/koha/circ/circulation.pl?borrowernumber= >7. IF you go back to the patron record the hold is not cancelled. >8. APPLY PATCH and clear the browser cache. >9. Try again, eveything should work! > >Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index 01e71e5b9c8..3e8f312d274 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -1023,7 +1023,10 @@ function toggleBtnIcon(element, start, replacement) { > */ > function holds_table_patron_page() { > var url = window.location.href; >- if (url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1) >+ if ( >+ url.indexOf("/circ/circulation.pl?borrowernumber=") !== -1 || >+ url.indexOf("/circ/circulation.pl?findborrower=") !== -1 >+ ) > return "circ"; > else if (url.indexOf("/members/moremember.pl?borrowernumber=") !== -1) > return "borrower"; >-- >2.51.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41211
:
189231
|
189365
| 189684