Bugzilla – Attachment 189776 Details for
Bug 41274
Incremental test runs not properly skipping Schema files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41274: Remove range parameter from ls_perl_files
c3544d9.patch (text/plain), 2.41 KB, created by
Jonathan Druart
on 2025-11-20 14:01:48 UTC
(
hide
)
Description:
Bug 41274: Remove range parameter from ls_perl_files
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-11-20 14:01:48 UTC
Size:
2.41 KB
patch
obsolete
>From c3544d967d9f57ce638319f6bd88b64f6213e0a0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 20 Nov 2025 14:32:40 +0100 >Subject: [PATCH] Bug 41274: Remove range parameter from ls_perl_files > >It's not used. >--- > Koha/Devel/Files.pm | 28 +++++++++------------------- > 1 file changed, 9 insertions(+), 19 deletions(-) > >diff --git a/Koha/Devel/Files.pm b/Koha/Devel/Files.pm >index ae4152b19a4..5bae4a02642 100644 >--- a/Koha/Devel/Files.pm >+++ b/Koha/Devel/Files.pm >@@ -13,7 +13,7 @@ Koha::Devel::Files - A utility module for managing and filtering file lists in t > > my $file_manager = Koha::Devel::Files->new( { context => 'tidy' } ); > >- my @perl_files = $file_manager->ls_perl_files($git_range); >+ my @perl_files = $file_manager->ls_perl_files(); > my @js_files = $file_manager->ls_js_files(); > my @tt_files = $file_manager->ls_tt_files(); > >@@ -186,30 +186,20 @@ sub ls_files { > > =head2 ls_perl_files > >- my @perl_files = $file_manager->ls_perl_files($git_range); >+ my @perl_files = $file_manager->ls_perl_files(); > >-Lists Perl files (with extensions .pl, .PL, .pm, .t) that have been modified within a specified Git range. If no range is provided, it lists all Perl files, excluding those specified in the exceptions. >+Lists Perl files (with extensions .pl, .PL, .pm, .t) in the repository, excluding those specified in the exceptions. > > =cut > > sub ls_perl_files { >- my ( $self, $git_range ) = @_; >+ my ($self) = @_; > my @files; >- if ($git_range) { >- $git_range =~ s|\.\.| |; >- my @modified_files = qx{git diff --name-only $git_range}; >- chomp @modified_files; >- push @files, grep { -e && /\.(pl|PL|pm|t)$/ } @modified_files; >- push @files, grep { -e && /^(svc|opac\/svc)/ } @modified_files; >- my @exception_files = $exceptions->{pl}->{ $self->{context} }; >- @files = array_minus( @files, @exception_files ); >- } else { >- my $cmd = >- sprintf q{git ls-files '*.pl' '*.PL' '*.pm' '*.t' svc opac/svc opac/unapi debian/build-git-snapshot %s}, >- $self->build_git_exclude('pl'); >- @files = qx{$cmd}; >- chomp for @files; >- } >+ my $cmd = >+ sprintf q{git ls-files '*.pl' '*.PL' '*.pm' '*.t' svc opac/svc opac/unapi debian/build-git-snapshot %s}, >+ $self->build_git_exclude('pl'); >+ @files = qx{$cmd}; >+ chomp for @files; > return @files; > } > >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41274
:
189716
| 189776 |
189777
|
189778