Bugzilla – Attachment 189789 Details for
Bug 34069
Add ability to restore a recently deleted borrower from deletedborrowers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34069: Fix HTML, Bootstrap classes, and QA complaints
Bug-34069-Fix-HTML-Bootstrap-classes-and-QA-compla.patch (text/plain), 3.01 KB, created by
Lucas Gass (lukeg)
on 2025-11-20 14:42:39 UTC
(
hide
)
Description:
Bug 34069: Fix HTML, Bootstrap classes, and QA complaints
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-11-20 14:42:39 UTC
Size:
3.01 KB
patch
obsolete
>From af45c42738a5561f3260a67471f6ff116020493a Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 17 Nov 2025 18:05:14 +0000 >Subject: [PATCH] Bug 34069: Fix HTML, Bootstrap classes, and QA complaints > >--- > Koha/Old/Patron.pm | 2 +- > .../prog/en/modules/tools/restore_deleted_borrowers.tt | 6 +++--- > tools/restore_deleted_borrowers.pl | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/Koha/Old/Patron.pm b/Koha/Old/Patron.pm >index a395a0ef839..870ffdbcfde 100644 >--- a/Koha/Old/Patron.pm >+++ b/Koha/Old/Patron.pm >@@ -81,7 +81,7 @@ sub restore_deleted_borrower { > > $schema->txn_do( > sub { >- # Retrive all the data about this patron from deleteborrowers table >+ # Retrieve all the data about this patron from deleteborrowers table > my $patron_data = $self->unblessed; > > # some fields must be cleared >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore_deleted_borrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore_deleted_borrowers.tt >index fa62e3ff29a..21c684788ed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore_deleted_borrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore_deleted_borrowers.tt >@@ -43,8 +43,8 @@ > <main> > [% IF view == "search" %] > <h1>Restore deleted patrons</h1> >- <div class="dialog alert bg-info-subtle"> >- <h3><i class="fa fa-exclamation-triangle"></i> Important: Limited restoration</h3> >+ <div class="alert alert-info"> >+ <h2><i class="fa fa-exclamation-triangle"></i> Important: Limited restoration</h2> > <p><strong>This tool ONLY restores the borrowers table and not related entries in other tables.</strong></p> > <p><strong>The following will NOT be restored because it is permanently deleted:</strong></p> > >@@ -316,7 +316,7 @@ > return false; > } > >- var message = __("Are you sure you want to restore %s patron(s)?").format(checked); >+ var message = _("Are you sure you want to restore %s patron(s)?").format(checked); > > if (!confirm(message)) { > e.preventDefault(); >diff --git a/tools/restore_deleted_borrowers.pl b/tools/restore_deleted_borrowers.pl >index 59eee5b1722..79946512722 100755 >--- a/tools/restore_deleted_borrowers.pl >+++ b/tools/restore_deleted_borrowers.pl >@@ -43,7 +43,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > } > ); > >-#check if the user can view patrons from any branch, or just thier own >+#check if the user can view patrons from any branch, or just their own > my $logged_in_patron = Koha::Patrons->find($loggedinuser); > my $can_view_all_libraries = > haspermission( $logged_in_patron->userid, { borrowers => 'view_borrower_infos_from_any_libraries' } ); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34069
:
188299
|
188302
|
188988
|
188989
|
188990
|
189027
|
189028
|
189029
|
189030
|
189037
|
189066
|
189067
|
189370
|
189371
|
189372
|
189373
|
189374
|
189375
|
189376
|
189377
|
189642
|
189645
|
189718
|
189773
|
189774
|
189779
|
189780
|
189781
|
189782
|
189783
|
189784
|
189785
|
189786
|
189787
|
189788
|
189789
|
189790
|
189791
|
189792
|
189793
|
189794
|
189795
|
189940
|
189941
|
189942
|
189943
|
189944
|
189945
|
189946
|
189947
|
189948
|
189949
|
189950
|
189951
|
189952
|
189953
|
189954