Bugzilla – Attachment 189828 Details for
Bug 41271
pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use'
32c25bd.patch (text/plain), 955 bytes, created by
Jonathan Druart
on 2025-11-21 08:47:06 UTC
(
hide
)
Description:
Bug 41271: Dont run Net::Server::PreFork->run on 'require' or 'use'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-11-21 08:47:06 UTC
Size:
955 bytes
patch
obsolete
>From 32c25bdd1c1062e9af04cbcb28fa2bf75d6952a0 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 20 Nov 2025 15:53:15 +0000 >Subject: [PATCH] Bug 41271: Dont run Net::Server::PreFork->run on 'require' or > 'use' > >By using 'unless caller' we ensure the class is not executed when Pod::Coverage->new does 'require C4/SIP/SIPServer.pm > >Ensure no regressions are added: >prove t/db_dependent/SIP/* > >koha-sip --restart kohadev >koha-sip --status kohadev > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/SIP/SIPServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm >index dff3af28b18..4cccd670af9 100644 >--- a/C4/SIP/SIPServer.pm >+++ b/C4/SIP/SIPServer.pm >@@ -91,7 +91,7 @@ push @params, 'group=' . $>; > > # > # This is the main event. >-__PACKAGE__->run(@params); >+__PACKAGE__->run(@params) unless caller; > > # > # Server >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41271
:
189713
|
189797
|
189798
|
189799
| 189828 |
189829
|
189830