Bugzilla – Attachment 189830 Details for
Bug 41271
pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41271: Revert follow-up from bug 37893
77c4b47.patch (text/plain), 945 bytes, created by
Jonathan Druart
on 2025-11-21 08:47:09 UTC
(
hide
)
Description:
Bug 41271: Revert follow-up from bug 37893
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-11-21 08:47:09 UTC
Size:
945 bytes
patch
obsolete
>From 77c4b478f54584ed1b47529a70e69c95acfdfd60 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Thu, 20 Nov 2025 15:57:38 +0000 >Subject: [PATCH] Bug 41271: Revert follow-up from bug 37893 > >This was a bad workaround. >It was ugly and is no longer relevant now that pod_coverage.t no longer attempts to launch a SIP server. > >prove xt/author/pod_coverage.t > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/SIP/Sip/Configuration.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/SIP/Sip/Configuration.pm b/C4/SIP/Sip/Configuration.pm >index 4a492f5d0de..b8e5075e031 100644 >--- a/C4/SIP/Sip/Configuration.pm >+++ b/C4/SIP/Sip/Configuration.pm >@@ -56,7 +56,7 @@ sub get_configuration { > } else { > $cfg = $current_config; > } >- die unless $cfg; >+ > my %listeners; > > # The key to the listeners hash is the 'port' component of the >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41271
:
189713
|
189797
|
189798
|
189799
|
189828
|
189829
| 189830