Bugzilla – Attachment 189850 Details for
Bug 41116
Selectors are inconsistently structured in hold found modals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41116: (follow-up) Some more fixes for consistency
Bug-41116-follow-up-Some-more-fixes-for-consistenc.patch (text/plain), 7.01 KB, created by
Owen Leonard
on 2025-11-21 14:28:48 UTC
(
hide
)
Description:
Bug 41116: (follow-up) Some more fixes for consistency
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-11-21 14:28:48 UTC
Size:
7.01 KB
patch
obsolete
>From 8bc2a23a91fdf70589be9c591eb7af1087f5a72e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 21 Nov 2025 07:42:22 -0500 >Subject: [PATCH] Bug 41116: (follow-up) Some more fixes for consistency > >- There was a mix of "patronphone" and "patron-phone" and I fixed it to > standardize on "patron-phone" (and patron-email) which I find easier > to read. >- I made similar changes to the branchtransfers template >- Corrected the TT filter on mailto links from "html" to "uri" >--- > .../prog/en/modules/circ/branchtransfers.tt | 4 +-- > .../prog/en/modules/circ/returns.tt | 26 +++++++++---------- > 2 files changed, 15 insertions(+), 15 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index 56dd990169..66cca9c4f2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -97,11 +97,11 @@ > </li> > [% INCLUDE display_holdpatron_address %] > [% IF ( patron.phone ) %] >- <li> [% patron.phone | html %]</li> >+ <li class="patron-phone"> [% patron.phone | html %]</li> > [% END %] > > [% IF ( patron.email ) %] >- <li><a id="boremail" href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li> >+ <li class="patron-email"><a href="mailto:[% patron.email | uri %]">[% patron.email | html %]</a></li> > [% END %] > > [% IF ( patron.is_debarred ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 161a638040..a05c8c3ea0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -77,15 +77,15 @@ > [% INCLUDE display_holdpatron_address %] > > [% IF ( patron.phone ) %] >- <li class="patronphone">[% patron.phone | html %]</li> >+ <li class="patron-phone">[% patron.phone | html %]</li> > [% END %] > > [% IF ( patron.email ) %] >- <li class="patronemail"> >+ <li class="patron-email"> > [% IF ( transfertodo ) %] > [% patron.email | html %] > [% ELSE %] >- <a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> >+ <a href="mailto:[% patron.email | uri %]">[% patron.email | html %]</a> > [% END %] > </li> > [% END %] >@@ -695,10 +695,10 @@ > </li> > [% INCLUDE display_holdpatron_address %] > [% IF ( patron.phone ) %] >- <li class="patronphone"> [% patron.phone | html %]</li> >+ <li class="patron-phone"> [% patron.phone | html %]</li> > [% END %] > [% IF ( patron.email ) %] >- <li class="patronemail"><a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a></li> >+ <li class="patron-email"><a href="mailto:[% patron.email | uri %]">[% patron.email | html %]</a></li> > [% END %] > > [% IF ( patron.smsalertnumber ) %] >@@ -907,11 +907,11 @@ > [% END %] > > [% IF ( patron.email ) %] >- <li class="patronemail"> >+ <li class="patron-email"> > [% IF ( transfertodo ) %] > [% patron.email | html %] > [% ELSE %] >- <a href="mailto:[% patron.email | html %]">[% patron.email | html %]</a> >+ <a href="mailto:[% patron.email | uri %]">[% patron.email | uri %]</a> > [% END %] > </li> > [% END %] >@@ -1008,15 +1008,15 @@ > [% INCLUDE display_holdpatron_address patron=recall.patron %] > > [% IF ( recall.patron.phone ) %] >- <l >[% recall.patron.phone | html %]</li> >+ <li class="patron-phone">[% recall.patron.phone | html %]</li> > [% END %] > > [% IF ( recall.patron.email ) %] >- <li> >+ <li class="patron-email"> > [% IF ( transfertodo ) %] > [% recall.patron.email | html %] > [% ELSE %] >- <a id="boremail" href="mailto:[% recall.patron.email | html %]">[% recall.patron.email | html %]</a> >+ <a href="mailto:[% recall.patron.email | uri %]">[% recall.patron.email | html %]</a> > [% END %] > </li> > [% END %] >@@ -1105,15 +1105,15 @@ > [% INCLUDE display_holdpatron_address patron=recall.patron %] > > [% IF ( recall.patron.phone ) %] >- <li>[% recall.patron.phone | html %]</li> >+ <li class="patron-phone">[% recall.patron.phone | html %]</li> > [% END %] > > [% IF ( recall.patron.email ) %] >- <li> >+ <li class="patron-email"> > [% IF ( transfertodo ) %] > [% recall.patron.email | html %] > [% ELSE %] >- <a id="boremail" href="mailto:[% recall.patron.email | html %]">[% recall.patron.email | html %]</a> >+ <a href="mailto:[% recall.patron.email | uri %]">[% recall.patron.email | html %]</a> > [% END %] > </li> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41116
:
188517
|
189849
| 189850