Bugzilla – Attachment 189852 Details for
Bug 40205
"Default checkout, hold and return policy" cannot be unset
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40205: data-categorycode should always be set to ALL
Bug-40205-data-categorycode-should-always-be-set-t.patch (text/plain), 1.81 KB, created by
Lucas Gass (lukeg)
on 2025-11-21 14:40:34 UTC
(
hide
)
Description:
Bug 40205: data-categorycode should always be set to ALL
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-11-21 14:40:34 UTC
Size:
1.81 KB
patch
obsolete
>From 0d7c7da93a1f3f30a4a7acdafc4e61f9de4c0ca4 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 21 Nov 2025 14:39:13 +0000 >Subject: [PATCH] Bug 40205: data-categorycode should always be set to ALL > >To test: >1. Add at least one rule to the default-circulation-rules table that contains a patron category. >2. Now add a "Default checkout, hold and return policy" rule. >3. Inspect the "Unset" button: > ><a href="#" class="delete-branch-cat btn btn-default btn-xs" data-categorycode="T" data-branch="*"><i class="fa fa-undo"></i> Unset</a> > >4. APPLY PATCH and clear browser cache >5. Try again, this time you should be able to delete the rule. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index a1b9d79a41e..bd0526017da 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -801,7 +801,7 @@ > <td class="actions"> > <button type="submit" class="btn btn-default btn-xs"><i class="fa fa-save"></i> Save</button> > [% IF ( default_checkout_hold_and_return_policy ) %] >- <a href="#" class="delete-branch-cat btn btn-default btn-xs" data-categorycode="[% c || '*' | html %]" data-branch="[% current_branch | html %]"><i class="fa fa-undo"></i> Unset</a> >+ <a href="#" class="delete-branch-cat btn btn-default btn-xs" data-categorycode="*" data-branch="[% current_branch | html %]"><i class="fa fa-undo"></i> Unset</a> > [% END %] > </td> > </tr> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40205
:
189852
|
189860