Bugzilla – Attachment 189917 Details for
Bug 41281
ILL request metadata doesn't show if falsy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41281: Only skip metadata if empty or undefined
Bug-41281-Only-skip-metadata-if-empty-or-undefined.patch (text/plain), 1.79 KB, created by
Pedro Amorim
on 2025-11-24 16:16:38 UTC
(
hide
)
Description:
Bug 41281: Only skip metadata if empty or undefined
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-11-24 16:16:38 UTC
Size:
1.79 KB
patch
obsolete
>From 7ffc550acaedcfe24dd8209d73d4e546689f3414 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Fri, 21 Nov 2025 15:49:16 +0000 >Subject: [PATCH] Bug 41281: Only skip metadata if empty or undefined > >1) Enable ILLModule >2) Create an ILL request: ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard >3) Pick any type, add '42' for cardnumber and any library >4) Edit item metadata (assuming ID 1): ><staff_url>/cgi-bin/koha/ill/ill-requests.pl?op=edititem&illrequest_id=1 >5) Click 'Add new field' under 'Custom fields' >6) Add any value for 'key' e.g. "test" and '0' for value. >7) Click 'Update'. Notice the custom field doesn't show. >8) Apply patch. Refresh. Verify it shows now. > >Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >index f579fe8aec8..3189db02885 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt >@@ -751,7 +751,7 @@ > <h4>Details from supplier ([% request.backend | html %])</h4> > <ol> > [% FOREACH meta IN request.metadata %] >- [% IF meta.value %] >+ [% IF meta.value.defined && meta.value.length %] > <li class="requestmeta-[% meta.key.replace('\s','_') | html %]"> > <span class="label">[% meta.key.replace('_',' ') | html %]:</span> > [% meta.value | html %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41281
:
189861
| 189917