Bugzilla – Attachment 189961 Details for
Bug 37402
Task scheduling fails if you don't use the correct time format
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37402: (follow-up) Add standard 'required' attributes and labels
Bug-37402-follow-up-Add-standard-required-attribut.patch (text/plain), 3.04 KB, created by
Owen Leonard
on 2025-11-26 14:32:29 UTC
(
hide
)
Description:
Bug 37402: (follow-up) Add standard 'required' attributes and labels
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-11-26 14:32:29 UTC
Size:
3.04 KB
patch
obsolete
>From 897d8b88e82f8ae66eb0a1601bc0e692d05f8ecf Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 26 Nov 2025 09:25:29 -0500 >Subject: [PATCH] Bug 37402: (follow-up) Add standard 'required' attributes and > labels > >This patch also moves time format hint into a standard <div >class="hint">. The hour format has been corrected from hhmm to HH:MM. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../prog/en/modules/tools/scheduler.tt | 22 ++++++++++++------- > 1 file changed, 14 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/scheduler.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/scheduler.tt >index 76cf5722bbf..5779a2a8a94 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/scheduler.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/scheduler.tt >@@ -36,7 +36,7 @@ > <div class="alert alert-info">Failed to add scheduled task</div> > [% END %] > >- <form name="form1" action="scheduler.pl" method="post"> >+ <form name="form1" action="scheduler.pl" method="post" class="validated"> > [% INCLUDE 'csrf-token.inc' %] > <input type="hidden" name="op" value="cud-add" /> > >@@ -44,10 +44,14 @@ > <legend>Task scheduler</legend > ><ol> > <li><span class="label">Current server time is:</span> [% time | html %]</li> >- <li><label for="starttime">Time: (set 24 hour time hhmm):</label> >- <input type="text" name="starttime" id="starttime" value="" maxlength="5" size="5" placeholder="hhmm" required /></li> >+ <li >+ ><label for="starttime" class="required">Time:</label> >+ <input type="text" name="starttime" id="starttime" value="" maxlength="5" size="5" placeholder="HH:MM" class="required" required /> >+ <span class="required">Required</span> >+ <div class="hint">Enter time in 24 hour format: HH:MM</div> >+ </li> > <li> >- <label for="startdate">Date: </label> >+ <label for="startdate" class="required">Date: </label> > <input type="text" size="10" id="startdate" name="startdate" class="flatpickr" data-flatpickr-futuredate="true" value="" /> > <div class="hint">[% INCLUDE 'date-format.inc' %]</div> > </li> >@@ -72,11 +76,13 @@ > </select> > </li> > <li >- ><label for="email">Email:</label> >+ ><label for="email" class="required">Email:</label> > >- <input type="text" name="email" id="email" size="50" /> >- </li> </ol >- ></fieldset> >+ <input type="email" class="required" name="email" id="email" size="50" /> >+ <span class="required">Required</span> >+ </li> >+ </ol></fieldset >+ > > <fieldset class="action"><input class="btn btn-primary" type="submit" value="Save" /></fieldset> > </form> > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37402
:
189897
|
189960
| 189961