Bugzilla – Attachment 190047 Details for
Bug 41216
Resurrect tt_valid.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41216: Fix QA failures
523c425.patch (text/plain), 2.68 KB, created by
Jonathan Druart
on 2025-12-01 13:57:38 UTC
(
hide
)
Description:
Bug 41216: Fix QA failures
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-12-01 13:57:38 UTC
Size:
2.68 KB
patch
obsolete
>From 523c425b029eaff16a40aeb5d23900e3a7366c6c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 1 Dec 2025 14:56:21 +0100 >Subject: [PATCH] Bug 41216: Fix QA failures > >--- > t/db_dependent/misc/translator/xgettext.pl.t | 4 ++-- > xt/author/tt_valid.t | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) > mode change 100644 => 100755 xt/author/tt_valid.t > >diff --git a/t/db_dependent/misc/translator/xgettext.pl.t b/t/db_dependent/misc/translator/xgettext.pl.t >index 9cb2aa63cf4..549539156dc 100755 >--- a/t/db_dependent/misc/translator/xgettext.pl.t >+++ b/t/db_dependent/misc/translator/xgettext.pl.t >@@ -74,7 +74,7 @@ is( scalar @$pot, 4, 'xgettext.pl generated a POT file' ); > > my $pot_content = read_file("$tempdir/Koha.pot"); > $pot_content =~ >- s|msgid "Don't use TT directives if another attribute is translatable"\nmsgstr ""|msgid "Don't use TT directives if another attribute is translatable"\nmsgstr "Ne pas utiliser TT si un autre attribut est traduisible"|gms; >+ s|msgid "Don't use TT directives if another attribute is translatable"\nmsgstr ""|msgid "Don't use TT directives if another attribute is translatable"\nmsgstr "Ne pas utiliser TT si un autre 'attribute' est traduisible"|gms; > $pot_content =~ s|msgid "Will be translated"\nmsgstr ""|msgid "Will be translated"\nmsgstr "Ceci sera traduit"|gms; > write_file( "$tempdir/Koha.pot", $pot_content ); > >@@ -84,7 +84,7 @@ my $install_cmd = > system($install_cmd); > > my $content = read_file("$tempdir_fr/tt/en/sample-not-working-2.tt"); >-like( $content, qr{Ne pas utiliser TT si un autre attribut est traduisible} ); >+like( $content, qr{Ne pas utiliser TT si un autre 'attribute' est traduisible} ); > like( $content, qr{Ceci sera traduit} ); > > # So far so good, but #FIXME: >diff --git a/xt/author/tt_valid.t b/xt/author/tt_valid.t >old mode 100644 >new mode 100755 >index f3433169961..0375deedbfd >--- a/xt/author/tt_valid.t >+++ b/xt/author/tt_valid.t >@@ -12,8 +12,8 @@ > # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > # GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, see <https://www.gnu.org/licenses>. > > use Modern::Perl; > use Test::NoWarnings; >@@ -110,6 +110,6 @@ For the time being, two validations are done: > This kind of construction MUST be avoided because it breaks Koha translation > process. > >-[2] Test tag <body> tags have both attibutes 'id' and 'class' >+[2] Test tag <body> tags have both attributes 'id' and 'class' > > =cut >-- >2.43.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41216
:
189316
|
189317
|
189318
|
189328
|
189329
|
189330
|
190046
| 190047