Bugzilla – Attachment 190057 Details for
Bug 41341
Some filters do not use the exact match in detail.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41341: [WIP] Reestablish exact matching on library/items
Bug-41341-WIP-Reestablish-exact-matching-on-librar.patch (text/plain), 1.99 KB, created by
Baptiste Wojtkowski (bwoj)
on 2025-12-01 15:59:20 UTC
(
hide
)
Description:
Bug 41341: [WIP] Reestablish exact matching on library/items
Filename:
MIME Type:
Creator:
Baptiste Wojtkowski (bwoj)
Created:
2025-12-01 15:59:20 UTC
Size:
1.99 KB
patch
obsolete
>From 5f081ea7eb85684cb5f069a1e5be26dd03936aa6 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Mon, 1 Dec 2025 15:57:00 +0000 >Subject: [PATCH] Bug 41341: [WIP] Reestablish exact matching on library/items > >Test plan >1 - Create a library with code "M" and an itemtype with code "B". >2 - Go on /cgi-bin/koha/catalogue/detail.pl?biblionumber=233 (a biblio with items from midway (MPL) and books (BK) >3 - Filter using library and itemtype created in 1 -> you will get some new filters >4 - Apply patch >5 - Test 3 again -> you should have no result anymore. >6 - Check that filters still work on libraries/items >--- > .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >index 003a1d37803..522ae9cb6b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc >@@ -236,8 +236,8 @@ > [% END %] > > var coded_values = { >- library: new Map(all_libraries.map( l => [l.branchname, l.branchcode] )), >- item_type: new Map(all_item_types.map( i => [i.translated_description, i.itemtype] )), >+ library: new Map(all_libraries.map( l => [l.branchname, "^" + l.branchcode + "$"] )), >+ item_type: new Map(all_item_types.map( i => [i.translated_description, "^" + i.itemtype + "$"] )), > collection_code: new Map([% To.json(AuthorisedValues.GetDescriptionsByKohaField({ kohafield => 'items.ccode' })) | $raw %].map( av => [av.lib, av.authorised_value])), > location: new Map([% To.json(AuthorisedValues.GetDescriptionsByKohaField({ kohafield => 'items.location' })) | $raw %].map( av => [av.lib, av.authorised_value])), > }; >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41341
: 190057 |
190072