Bugzilla – Attachment 190104 Details for
Bug 41354
Error when loading "Record sources" Vue app
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41354: Fix record sources Vue app
8c5ff31.patch (text/plain), 1.64 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-12-03 11:35:35 UTC
(
hide
)
Description:
Bug 41354: Fix record sources Vue app
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-12-03 11:35:35 UTC
Size:
1.64 KB
patch
obsolete
>From 8c5ff311ed9090af00f77fc91cbe15472bb86086 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Dec 2025 14:02:38 +0100 >Subject: [PATCH] Bug 41354: Fix record sources Vue app >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >It fixes a JS error in the console >Uncaught (in promise) TypeError: can't convert undefined to object > >Also fixes the cypress tests: >t/cypress/integration/Admin/RecordSources_spec.ts > >Test plan: >Create a new record source > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../intranet-tmpl/prog/js/vue/components/ResourceList.vue | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue >index 1d4038acac..7b8d51aee1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ResourceList.vue >@@ -290,9 +290,9 @@ export default { > ).map(col => { > const filterOptions = > props.instancedResource.tableOptions.filters_options; >- const filterRequired = Object.keys(filterOptions).includes( >- col.data >- ); >+ const filterRequired = >+ filterOptions && >+ Object.keys(filterOptions).includes(col.data); > if (filterRequired) { > col.dataFilter = col.data; > } >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41354
:
190078
|
190093
| 190104