Bugzilla – Attachment 190112 Details for
Bug 41336
Vue Router warn on Vue datatable pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41336: Remove 'No match found for location with path' warnings
9f74425.patch (text/plain), 3.22 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-12-03 13:44:13 UTC
(
hide
)
Description:
Bug 41336: Remove 'No match found for location with path' warnings
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-12-03 13:44:13 UTC
Size:
3.22 KB
patch
obsolete
>From 9f74425d77bdf4611fdb1bbb2f9e65feb89cc530 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Dec 2025 13:33:08 +0100 >Subject: [PATCH] Bug 41336: Remove 'No match found for location with path' > warnings >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Cypress tests for Vue app are currently failing because of the following >warnings in the console: >"[Vue Router warn] No match found for location with path" > >It happens for routes that are disabled. We should not build a >router-link but a "disabled" link instead. > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../prog/js/vue/components/NavigationItem.vue | 28 +++++++------------ > 1 file changed, 10 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >index 5bb744c0aa..b3179f412a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >@@ -1,42 +1,34 @@ > <template> > <li class="breadcrumb-item"> > <span> >+ <a v-if="item.disabled" href="#" class="{ disabled: disabled }"> >+ <template v-if="item.icon"> >+ <i :class="`${item.icon}`"></i> >+ </template> >+ <span v-if="item.title">{{ $__(item.title) }}</span> >+ </a> > <router-link >- v-if="item.name" >+ v-else-if="item.name" > :to="{ name: item.name, params }" >- :class="{ disabled: item.disabled }" > > > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </router-link> >- <router-link >- v-else-if="item.path" >- :to="item.path" >- :class="{ disabled: item.disabled }" >- > >+ <router-link v-else-if="item.path" :to="item.path"> > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </router-link> >- <a >- v-else-if="item.href" >- :href="item.href" >- :class="{ disabled: item.disabled }" >- > >+ <a v-else-if="item.href" :href="item.href"> > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </a> >- <a >- v-else >- href="#" >- aria-current="page" >- :class="{ disabled: item.disabled }" >- > >+ <a v-else href="#" aria-current="page"> > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41336
:
190077
|
190079
|
190107
|
190108
| 190112 |
190113
|
190114