Bugzilla – Attachment 190113 Details for
Bug 41336
Vue Router warn on Vue datatable pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41336: Fix current (?)
50f610c.patch (text/plain), 3.16 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-12-03 13:44:16 UTC
(
hide
)
Description:
Bug 41336: Fix current (?)
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-12-03 13:44:16 UTC
Size:
3.16 KB
patch
obsolete
>From 50f610c02c4a72316abf533f6103fb4c465d6118 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 2 Dec 2025 14:17:27 +0100 >Subject: [PATCH] Bug 41336: Fix current (?) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >On top of "Bug 41354: Fix record sources Vue app" there is still one >failing test for t/cypress/integration/Admin/RecordSources_spec.ts > > 1) Breadcrumbs tests > Breadcrumbs: > AssertionError: Timed out retrying after 10000ms: Expected to find element: `.current`, but never found it. > at Context.eval (webpack://koha/./t/cypress/integration/Admin/RecordSources_spec.ts:18:11) > >This patch is trying to fix it but it does not > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > .../prog/js/vue/components/NavigationItem.vue | 22 ++++++++++--------- > 1 file changed, 12 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >index b3179f412a..59597e4997 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/NavigationItem.vue >@@ -1,14 +1,8 @@ > <template> > <li class="breadcrumb-item"> > <span> >- <a v-if="item.disabled" href="#" class="{ disabled: disabled }"> >- <template v-if="item.icon"> >- <i :class="`${item.icon}`"></i> >- </template> >- <span v-if="item.title">{{ $__(item.title) }}</span> >- </a> > <router-link >- v-else-if="item.name" >+ v-if="item.name && !item.disabled" > :to="{ name: item.name, params }" > > > <template v-if="item.icon"> >@@ -16,19 +10,27 @@ > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </router-link> >- <router-link v-else-if="item.path" :to="item.path"> >+ <router-link >+ v-else-if="item.path && !item.disabled" >+ :to="item.path" >+ > > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </router-link> >- <a v-else-if="item.href" :href="item.href"> >+ <a v-else-if="item.href && !item.disabled" :href="item.href"> > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> > <span v-if="item.title">{{ $__(item.title) }}</span> > </a> >- <a v-else href="#" aria-current="page"> >+ <a >+ v-else >+ href="#" >+ aria-current="page" >+ :class="{ disabled: item.disabled }" >+ > > <template v-if="item.icon"> > <i :class="`${item.icon}`"></i> > </template> >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41336
:
190077
|
190079
|
190107
|
190108
|
190112
| 190113 |
190114