Bugzilla – Attachment 190122 Details for
Bug 41364
Error in preservation module breadcrumb
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41364: Fix error in preservation module breadcrumb
64566c8.patch (text/plain), 2.33 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-12-03 15:56:05 UTC
(
hide
)
Description:
Bug 41364: Fix error in preservation module breadcrumb
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-12-03 15:56:05 UTC
Size:
2.33 KB
patch
obsolete
>From 64566c83860bf05953ffb870d985a296ef549116 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Tom=C3=A1s=20Cohen=20Arazi?= <tomascohen@theke.io> >Date: Wed, 3 Dec 2025 12:47:27 -0300 >Subject: [PATCH] Bug 41364: Fix error in preservation module breadcrumb >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: > >- Breadcrumb element empty >- Error in the browser console > >To test: >1. Enable the Preservation module >2. Go to Home > Preservation > Settings >3. Use the 'Add a new processing' button >=> FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) >4. Click on 'Edit this processing' >=> FAIL: Same error, different context >5. Check the browser console >=> FAIL: You see something like this: > >``` >[Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 >``` > >6. Run the cypress tests for this module: > k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts >=> FAIL: The breadcrumb navigation is broken >7. Apply this patch >8. Rebuild things: > $ ktd --shell > k$ yarn build >9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) >10. Repeat 2-6 >=> SUCCESS: The breadcrumb is no longer broken >=> SUCCESS: No errors/warnings about this in the browser console >=> SUCCESS: Tests pass! >11. Sign off :-D > >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/vue/routes/preservation.js | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/preservation.js b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/preservation.js >index e78b55a8ec..302668f9b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/routes/preservation.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/routes/preservation.js >@@ -128,6 +128,8 @@ export const routes = [ > }, > { > path: "processings", >+ title: $__("Processings"), >+ disabled: true, > children: [ > { > path: ":processing_id", >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41364
:
190122
|
190124