Bugzilla – Attachment 19018 Details for
Bug 8884
opacheader is not in the header on CCSR
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8884: opacheader is not in the header on CCSR
Bug-8884-opacheader-is-not-in-the-header-on-CCSR.patch (text/plain), 1.92 KB, created by
Kyle M Hall (khall)
on 2013-06-14 16:10:09 UTC
(
hide
)
Description:
Bug 8884: opacheader is not in the header on CCSR
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-06-14 16:10:09 UTC
Size:
1.92 KB
patch
obsolete
>From dc95fb31b2da1de217d0a5d750a40e6d09963811 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Mon, 20 May 2013 12:55:17 -0400 >Subject: [PATCH] Bug 8884: opacheader is not in the header on CCSR > >In CCSR the opacheader preference isn't really in the header it's to the >right of the search box (see attached). I'm okay with a customizable >region over there, but we should have a new preference for that and >header should be above the search box as it implies. > >To test: >1) Put something in the OpacHeader syspref. Preferably something large > and header-like for maximum effect. >2) Select CCSR theme. >3) View OPAC. Notice placement of "header" content. >4) Apply patch. >5) View OPAC. Notice placement of "header" content. >6) Sign off. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Passes koha-qa.pl, works as advertised with one caveat; the content of >opacheader is by default underneath the div "top-bar". A couple breaks >in my OpacHeader test made it visible, so I'm going to assume this is a >styling issue and not a bug as such. >--- > koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc | 12 +++++++----- > 1 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >index ec699f4..0069f74 100644 >--- a/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc >@@ -74,6 +74,12 @@ > > </div> > >+<div id="opac-custom-header"> >+[% IF ( opacheader ) %] >+ [% opacheader %] >+[% END %] >+</div> >+ > <div id="opac-main-search" class="yui-g"> > > <a class="logo" href="/cgi-bin/koha/opac-main.pl"> >@@ -279,11 +285,7 @@ > </div> > > <div id="libraryname"> >- [% IF ( opacheader ) %] >- <h1> >- [% opacheader %] >- </h1> >- [% END %] >+ <h1></h1> > </div> > > [% END %] <!-- OpacPublic --> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8884
:
12720
|
18261
|
18396
|
19018
|
19027
|
19028
|
19029
|
19198