Bugzilla – Attachment 19019 Details for
Bug 7110
Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7110 - Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled
Bug-7110---Renewal-messages-still-displays-in-OPAC.patch (text/plain), 3.50 KB, created by
Kyle M Hall (khall)
on 2013-06-14 16:37:12 UTC
(
hide
)
Description:
Bug 7110 - Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2013-06-14 16:37:12 UTC
Size:
3.50 KB
patch
obsolete
>From 3969b21c91927463e22656777e9b97bb504c55d9 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 27 Nov 2012 11:16:14 -0500 >Subject: [PATCH] Bug 7110 - Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled > >The original patch added a message to display if OpacRenewalAllowed >is disabled but OPACFineNoRenewals is enabled. This change was >reversed by a follow-up on Bug 8408. > >I think both versions are incorrect: If a patron has fines which >exceed the limit set by OPACFineNoRenewals but OPAC renewals are >disallowed by OpacRenewalAllowed, no message should be displayed. >Information about outstanding fines in this case has no bearing on >how the user sees his summary of checkouts. > >To test, try various combinations of OpacRenewalAllowed and >OPACFineNoRenewals with a patron who has outstanding fines: > >- OpacRenewalAllowed ON and OPACFineNoRenewals ON (set to be triggered > by the test patron's fines): Logging in to the OPAC the patron should > see a warning on opac-user.pl about not being able to renew items > because of fines. > >- OpacRenewalAllowed ON and OPACFineNoRenewals OFF (threshold high > enough not to trigger a block): No warning appears. > >- OpacRenewalAllowed OFF and OPACFineNoRenewals ON: No warning appears. > >- OpacRenewalAllowed OFF and OPACFineNoRenewals OFF: No warning appears. > >If OpacRenewalAllowed is diabled and a patron's fines exceed the limit >set by OPACFineNoRenewals they should see no message. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > >Passes koha-ql.pl and perlcritic >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 2 -- > opac/opac-user.pl | 2 +- > 2 files changed, 1 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >index 9ec4891..41ab539 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt >@@ -112,8 +112,6 @@ $.tablesorter.addParser({ > [% END %] > [% IF ( renewal_blocked_fines ) && ( OpacRenewalAllowed ) %] > <span id="renewal_blocked_fines"><li><strong>Please note: </strong> Since you have <a href="/cgi-bin/koha/opac-account.pl">[% IF renewal_blocked_fines != "0.00" %] more than <span id="renewal_blocked_fines_amount">[% renewal_blocked_fines %]</span> in [% END %] fines</a>, you cannot renew your books online. Please pay your fines if you wish to renew your books.</li></span> >- [% ELSIF ( renewal_blocked_fines ) %] >- <span id="renewal_blocked_fines"><li><strong>Please note: </strong> You currently owe <a href="/cgi-bin/koha/opac-account.pl"><span id="renewal_blocked_fines_amount">[% renewal_blocked_fines_amountoutstanding %] in fines. Please pay your fines if you wish to renew your books.</span></a></li></span> > [% END %] > </ul></div> > [% END %] >diff --git a/opac/opac-user.pl b/opac/opac-user.pl >index 7b2f25e..5c01ae2 100755 >--- a/opac/opac-user.pl >+++ b/opac/opac-user.pl >@@ -105,7 +105,7 @@ if ( 5 >= $borr->{'amountoutstanding'} && $borr->{'amountoutstanding'} > 0 ) { > my $no_renewal_amt = C4::Context->preference( 'OPACFineNoRenewals' ); > $no_renewal_amt ||= 0; > >-if ( $borr->{amountoutstanding} > $no_renewal_amt ) { >+if ( C4::Context->preference( 'OpacRenewalAllowed' ) && $borr->{amountoutstanding} > $no_renewal_amt ) { > $borr->{'flagged'} = 1; > $canrenew = 0; > $template->param( >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7110
:
6094
|
6103
|
7709
|
7765
|
13706
|
18052
|
18488
| 19019