Bugzilla – Attachment 190246 Details for
Bug 6473
Test bug for Git-bz ✔ ❤ ★
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40524: Update print format to use built-in formatter
64151b2.patch (text/plain), 2.72 KB, created by
Tomás Cohen Arazi (tcohen)
on 2025-12-05 17:44:16 UTC
(
hide
)
Description:
Bug 40524: Update print format to use built-in formatter
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2025-12-05 17:44:16 UTC
Size:
2.72 KB
patch
obsolete
>From 64151b20acd9786d7fec35c20b807961e3820794 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 28 Jul 2025 03:26:43 +0000 >Subject: [PATCH] Bug 40524: Update print format to use built-in formatter > >This change updates the print format to use the built-in formatter >for operations like trim, strip HTML, strip newlines, and not >decoding entities. > >Test plan: >0. Apply the patch >1. Go to http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno=1 >2. Click "add to basket" >3. Type "test" next to "From an existing record" and click "Submit" >4. On the "Gairm" row, click "Add order" >5. Fill in the required fields >6. In the "Internal note" put the following: >abc123 >7. Click "Save" >8. In the Orders table, click "Export" and then "Print" >9. Note that the print page loads correctly, you can see the internal note, >and you cannot see lines for "Add internal note", >"Edit internal note", or "Add vendor note" > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/js/datatables.js | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >index 2a958ef20c..6ebe226e18 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js >@@ -796,6 +796,26 @@ function _dt_buttons(params) { > }, > }; > >+ const export_format_print = { >+ body: function (data, row, column, node) { >+ const newnode = node.cloneNode(true); >+ const no_export_nodes = newnode.querySelectorAll(".no-export"); >+ no_export_nodes.forEach(child => { >+ child.parentNode.removeChild(child); >+ }); >+ //Note: innerHTML is the same thing as the data variable, >+ //minus the ".no-export" nodes that we've removed >+ //Note: See dataTables.buttons.js for original function usage >+ const str = DataTable.Buttons.stripData(newnode.innerHTML, { >+ decodeEntities: false, >+ stripHtml: true, >+ stripNewlines: true, >+ trim: true, >+ }); >+ return str; >+ }, >+ }; >+ > var export_format = { > body: function (data, row, column, node) { > var newnode = $(node); >@@ -835,7 +855,7 @@ function _dt_buttons(params) { > extend: "print", > exportOptions: { > columns: exportColumns, >- format: export_format, >+ format: export_format_print, > }, > }, > ]; >-- >2.50.1 (Apple Git-155) >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6473
:
4386
|
6837
|
6838
|
6839
|
6840
|
6841
|
6842
|
6843
|
7154
|
7155
|
7567
|
7994
|
7995
|
7996
|
7997
|
8018
|
9807
|
9808
|
9813
|
9831
|
9832
|
9836
|
9854
|
10842
|
10843
|
10844
|
10845
|
10846
|
10847
|
10848
|
10849
|
10850
|
10851
|
10852
|
10853
|
10854
|
10855
|
10856
|
10857
|
10858
|
11540
|
11543
|
11544
|
12502
|
12513
|
12514
|
12515
|
12516
|
12517
|
12518
|
12519
|
13473
|
13673
|
14955
|
14969
|
14970
|
14972
|
15201
|
18949
|
18950
|
18951
|
18952
|
18953
|
18954
|
18955
|
18956
|
18957
|
18958
|
18959
|
18960
|
18961
|
18962
|
18963
|
18971
|
18972
|
19518
|
19519
|
19591
|
19592
|
19871
|
19879
|
19880
|
19881
|
19882
|
20011
|
20012
|
20013
|
20014
|
22477
|
22481
|
22482
|
22496
|
22502
|
22503
|
31958
|
32444
|
32445
|
32446
|
32447
|
32448
|
32449
|
32450
|
32451
|
32452
|
34200
|
34201
|
34625
|
34999
|
35130
|
35269
|
35273
|
35274
|
35275
|
35276
|
35277
|
35279
|
35280
|
35303
|
40954
|
40957
|
45345
|
45349
|
45731
|
45732
|
45733
|
45734
|
47283
|
47284
|
47298
|
47299
|
47300
|
47334
|
47336
|
49083
|
56974
|
61059
|
61069
|
62038
|
65313
|
77301
|
78016
|
79959
|
80178
|
80179
|
80180
|
80181
|
80182
|
84400
|
86644
|
86645
|
87152
|
88128
|
95586
|
95716
|
97394
|
99026
|
99027
|
114217
|
114218
|
114219
|
114220
|
114221
|
114222
|
114223
|
114224
|
114225
|
114226
|
119255
|
121181
|
131891
|
131893
|
131894
|
134862
|
144109
|
144144
|
144671
|
144672
|
144673
|
147183
|
149030
|
149031
|
149032
|
149033
|
160566
|
160567
|
160568
|
182093
|
183107
|
183177
|
183178
|
183179
|
183180
|
183182
|
183183
|
183285
|
183286
|
187209
|
187321
|
187322
|
187323
|
187324
|
187325
|
187326
|
187327
|
187328
|
187329
|
187330
|
187331
|
187332
|
187333
|
187334
|
187335
|
187336
|
187337
|
187338
|
187339
|
187340
|
187341
|
187342
|
187343
|
187344
|
187345
|
187346
|
187347
|
187348
|
187349
|
187350
|
187351
|
187352
|
187353
|
187354
|
187355
|
187356
|
187357
|
187358
|
187359
|
187360
|
187361
|
187362
|
187363
|
187364
|
187365
|
187366
|
187367
|
187368
|
187369
|
187370
|
187371
|
187372
|
187545
|
187546
|
188609
|
188610
|
188611
|
188612
|
188613
|
188614
|
188626
|
188627
|
188628
|
188629
|
188630
|
188631
|
188632
|
188633
|
188634
|
188645
|
188647
|
188703
|
188929
|
188937
|
188975
|
190164
|
190165
|
190166
|
190167
|
190168
|
190169
|
190170
|
190171
|
190172
|
190173
|
190174
|
190175
|
190176
|
190177
|
190178
|
190179
|
190180
|
190181
|
190182
|
190183
|
190184
|
190185
|
190186
|
190187
|
190188
|
190240
|
190241
|
190242
|
190243
|
190244
|
190245
|
190246
|
190247
|
190248
|
190249
|
190250
|
190251
|
190252
|
190253
|
190255
|
190256