Bugzilla – Attachment 190272 Details for
Bug 40287
Fix untranslatable strings in more statistics wizards
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40287: (follow-up) Use GetDescriptionByKohaField for item fields
Bug-40287-follow-up-Use-GetDescriptionByKohaField-.patch (text/plain), 4.73 KB, created by
David Nind
on 2025-12-06 20:18:39 UTC
(
hide
)
Description:
Bug 40287: (follow-up) Use GetDescriptionByKohaField for item fields
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-12-06 20:18:39 UTC
Size:
4.73 KB
patch
obsolete
>From c8a4ce4f2e5a663238e2a3d2eaa64e0842f23cf3 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 21 Jul 2025 13:52:18 +0000 >Subject: [PATCH] Bug 40287: (follow-up) Use GetDescriptionByKohaField for item > fields > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/reports/acquisitions_stats.tt | 4 ++-- > .../prog/en/modules/reports/catalogue_stats.tt | 6 +++--- > .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 4 ++-- > 3 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >index c53eabaed6..c1b6c1211b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/acquisitions_stats.tt >@@ -74,8 +74,8 @@ > <strong>Home library: </strong> > [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE '6' %] >- <strong>Collection: </strong> >- [% AuthorisedValues.GetByCode( 'CCODE', loopfilte.filter ) | html %] >+ <strong>Collection:</strong> >+ [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => loopfilte.filter ) %] > [% CASE '7' %] > <strong>Item type: </strong> > [% ItemTypes.GetDescription( loopfilte.filter ) | html %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >index 7ba47569ae..c49ebfccd2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt >@@ -68,11 +68,11 @@ > [% CASE "Library" %] > <strong>Library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE "Shelving Location" %] >- <strong>Location:</strong> [% AuthorisedValues.GetByCode( 'LOC', loopfilte.filter ) | html %] >+ <strong>Location:</strong> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => loopfilte.filter ) %] > [% CASE "Collection Code" %] >- <strong>Collection:</strong> [% AuthorisedValues.GetByCode( 'CCODE', loopfilte.filter ) | html %] >+ <strong>Collection:</strong> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => loopfilte.filter ) %] > [% CASE "Status" %] >- <strong>Not for loan:</strong> [% AuthorisedValues.GetByCode( 'NOT_LOAN', loopfilte.filter ) | html %] >+ <strong>Not for loan:</strong> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => loopfilte.filter ) %] > [% CASE "Materials" %] > <strong>Materials specified:</strong> [% loopfilte.filter | html %] > [% CASE "Barcode (not like)" %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index 9267a8dbff..c4d9bf34a5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -82,9 +82,9 @@ > [% CASE 4 %] > <strong>Issuing library:</strong> [% Branches.GetName( loopfilte.filter ) | html %] > [% CASE 5 %] >- <strong>Collection:</strong> [% AuthorisedValues.GetByCode( 'CCODE', loopfilte.filter ) | html %] >+ <strong>Collection:</strong> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => loopfilte.filter ) %] > [% CASE 6 %] >- <strong>Location:</strong> [% AuthorisedValues.GetByCode( 'LOC', loopfilte.filter ) | html %] >+ <strong>Location:</strong> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => loopfilte.filter ) %] > [% CASE 7 %] > <strong>Item call number > [% loopfilte.filter | html %] </strong> > [% CASE 8 %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40287
:
184201
|
184451
|
190271
|
190272
|
190348
|
190349