Bugzilla – Attachment 19044 Details for
Bug 10439
Cannot modify the notice's library
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 10439: FIX modify the library for a notice.
PASSED-QA-Bug-10439-FIX-modify-the-library-for-a-n.patch (text/plain), 1.68 KB, created by
Katrin Fischer
on 2013-06-16 16:50:50 UTC
(
hide
)
Description:
[PASSED QA] Bug 10439: FIX modify the library for a notice.
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-06-16 16:50:50 UTC
Size:
1.68 KB
patch
obsolete
>From 473f11731c7d6e7ba6e493d91fa137665852795f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 10 Jun 2013 14:05:32 +0200 >Subject: [PATCH] [PASSED QA] Bug 10439: FIX modify the library for a notice. > >2 javascript functions should be apply only in a specific case, not for all >views. > >Test plan: >- switch on the IndependentBranches pref >- try to change the library for a notice. Before the patch, no change is >applied. > >Signed-off-by: Srdjan <srdjan@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> > >Note: only a superlibrarian can change the library or create new >notices for every library. This bug can only be reproduced with >superlibrarian permissions. > >Tested with independentbranches on/off. >All tests and QA script pass. >--- > .../intranet-tmpl/prog/en/modules/tools/letter.tt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >index f210715..52e2b83 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt >@@ -15,14 +15,16 @@ $(document).ready(function() { > ], > "bPaginate": false > })); >- $('#branch').change(function() { >+ [% IF no_op_set %] >+ $('#branch').change(function() { > $('#op').val(""); > $('#selectlibrary').submit(); >- }); >- $('#newnotice').click(function() { >+ }); >+ $('#newnotice').click(function() { > $('#op').val("add_form"); > return true; >- }); >+ }); >+ [% END %] > }); > [% IF ( add_form ) %] > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10439
:
18818
|
18830
| 19044