Bugzilla – Attachment 190487 Details for
Bug 41420
Syntax error in referrer in parcel.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41420: Fix referrer in parcel.tt
Bug-41420-Fix-referrer-in-parceltt.patch (text/plain), 2.05 KB, created by
David Nind
on 2025-12-13 23:17:47 UTC
(
hide
)
Description:
Bug 41420: Fix referrer in parcel.tt
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-12-13 23:17:47 UTC
Size:
2.05 KB
patch
obsolete
>From 08418fc7085e08d98d1af34a562d7e94a69a2ca9 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Wed, 10 Dec 2025 09:49:36 +0000 >Subject: [PATCH] Bug 41420: Fix referrer in parcel.tt > >Test plan: > >Steps to reproduce : >1 - Go to http://localhost:8081/cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&basketno=1 and fill in a new item. >2 - Visit http://localhost:8081/cgi-bin/koha/acqui/parcels.pl?booksellerid=1, type an invoice name and validate. Inspect both "Cancel order" and "Cancel order and catalog record". Notice the link in "Cancel order is broken" >3 - Apply patch >4 - Repeat 3 and notice the referrer is well formed. > >For a reason I ignore, it does not seem to have an impact on main, but >on the 24.11 I tested, if you click on cancel order, after confirming >the deletion and clicking on "ok", you will be asked again to confirm, > however the deletion has been performed > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 410c55d95c..be11e342a9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -614,7 +614,7 @@ > else { > result += '<a href="/cgi-bin/koha/acqui/cancelorder.pl?ordernumber=' > + encodeURIComponent(row.order_id) + '&biblionumber=' + encodeURIComponent(row.biblio_id) >- + '&del_biblio=1&referrer="/cgi-bin/koha/acqui/parcel.pl?invoiceid=[$ invoiceid | uri ]">' >+ + '&del_biblio=1&referrer=/cgi-bin/koha/acqui/parcel.pl?invoiceid=[% invoiceid | uri %]">' > + _("Cancel order and catalog record") + '</a><br/>'; > } > >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41420
:
190390
| 190487