Bugzilla – Attachment 190535 Details for
Bug 41454
Remove unused dbh calls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41454: Remove unused dbh calls
Bug-41454-Remove-unused-dbh-calls.patch (text/plain), 9.36 KB, created by
Peter Vashchuk
on 2025-12-16 12:09:49 UTC
(
hide
)
Description:
Bug 41454: Remove unused dbh calls
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2025-12-16 12:09:49 UTC
Size:
9.36 KB
patch
obsolete
>From d20a9e56ecd3ced2f06fe751f095099a9208d3a8 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Tue, 16 Dec 2025 14:09:02 +0200 >Subject: [PATCH] Bug 41454: Remove unused dbh calls > >--- > C4/Biblio.pm | 1 - > C4/Circulation.pm | 1 - > C4/InstallAuth.pm | 1 - > C4/Search.pm | 2 -- > C4/XISBN.pm | 1 - > acqui/histsearch.pl | 1 - > acqui/newordersuggestion.pl | 1 - > authorities/authorities-home.pl | 1 - > cataloguing/value_builder/marc21_linking_section.pl | 1 - > cataloguing/value_builder/unimarc_field_100.pl | 2 -- > cataloguing/value_builder/unimarc_field_100_authorities.pl | 2 -- > cataloguing/value_builder/unimarc_field_105.pl | 1 - > cataloguing/value_builder/unimarc_field_106.pl | 1 - > cataloguing/value_builder/unimarc_field_110.pl | 1 - > cataloguing/value_builder/unimarc_field_115a.pl | 1 - > opac/opac-search-history.pl | 1 - > 16 files changed, 19 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index cdfde492d65..2a16f3f792c 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -2917,7 +2917,6 @@ sub ModBiblioMarc { > > # Clone record as it gets modified > $record = $record->clone(); >- my $dbh = C4::Context->dbh; > my @fields = $record->fields(); > my $encoding = C4::Context->preference("marcflavour"); > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 0b2b57e3754..ed1a6648b8e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -431,7 +431,6 @@ sub TooMany { > my $onsite_checkout = $params->{onsite_checkout} || 0; > my $switch_onsite_checkout = $params->{switch_onsite_checkout} || 0; > my $cat_borrower = $patron->categorycode; >- my $dbh = C4::Context->dbh; > > # Get which branchcode we need > my $branch = _GetCircControlBranch( $item, $patron ); >diff --git a/C4/InstallAuth.pm b/C4/InstallAuth.pm >index 7e3271dd2e4..cca540388f6 100644 >--- a/C4/InstallAuth.pm >+++ b/C4/InstallAuth.pm >@@ -236,7 +236,6 @@ sub checkauth { > my $type = shift; > $type = 'intranet' unless $type; > >- my $dbh = C4::Context->dbh(); > my $template_name; > $template_name = "installer/auth.tt"; > >diff --git a/C4/Search.pm b/C4/Search.pm >index 5d6f3c6e33d..13de6df6937 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -88,7 +88,6 @@ This function attempts to find duplicate records using a hard-coded, fairly simp > > sub FindDuplicate { > my ($record) = @_; >- my $dbh = C4::Context->dbh; > my $result = TransformMarcToKoha( { record => $record } ); > my $sth; > my $query; >@@ -1659,7 +1658,6 @@ Format results in a form suitable for passing to the template > # building the HTML output for the template > sub searchResults { > my ( $search_context, $searchdesc, $hits, $results_per_page, $offset, $scan, $marcresults, $xslt_variables ) = @_; >- my $dbh = C4::Context->dbh; > my @newresults; > > require C4::Items; >diff --git a/C4/XISBN.pm b/C4/XISBN.pm >index 6777c81662f..02a62dabb48 100644 >--- a/C4/XISBN.pm >+++ b/C4/XISBN.pm >@@ -51,7 +51,6 @@ This module provides facilities for retrieving ThingISBN and XISBN content in Ko > > sub _get_biblio_from_xisbn { > my $xisbn = shift; >- my $dbh = C4::Context->dbh; > > my $searcher = Koha::SearchEngine::Search->new( { index => $Koha::SearchEngine::BIBLIOS_INDEX } ); > my ( $errors, $results, $total_hits ) = $searcher->simple_search_compat( "nb=$xisbn", 0, 1 ); >diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl >index 9d1e76f0085..f101e08b3e0 100755 >--- a/acqui/histsearch.pl >+++ b/acqui/histsearch.pl >@@ -60,7 +60,6 @@ use Koha::DateUtils qw( dt_from_string ); > my $input = CGI->new; > my $do_search = $input->param('do_search') || 0; > >-my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { > template_name => "acqui/histsearch.tt", >diff --git a/acqui/newordersuggestion.pl b/acqui/newordersuggestion.pl >index 02bfa2cfc3b..9c9165fb748 100755 >--- a/acqui/newordersuggestion.pl >+++ b/acqui/newordersuggestion.pl >@@ -115,7 +115,6 @@ my $link_order = $input->param('link_order'); > > $op = 'else' unless $op; > >-my $dbh = C4::Context->dbh; > my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > { > template_name => "acqui/newordersuggestion.tt", >diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl >index 798df8afc10..8317db247ca 100755 >--- a/authorities/authorities-home.pl >+++ b/authorities/authorities-home.pl >@@ -37,7 +37,6 @@ use Koha::XSLT::Base; > use Koha::Z3950Servers; > > my $query = CGI->new; >-my $dbh = C4::Context->dbh; > my $op = $query->param('op') || ''; > my $authtypecode = $query->param('authtypecode') || ''; > my $authid = $query->param('authid') || ''; >diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl >index 54621596809..2218c049ccf 100755 >--- a/cataloguing/value_builder/marc21_linking_section.pl >+++ b/cataloguing/value_builder/marc21_linking_section.pl >@@ -55,7 +55,6 @@ my $builder = sub { > my $launcher = sub { > my ($params) = @_; > my $query = $params->{cgi}; >- my $dbh = C4::Context->dbh; > my $op = $query->param('op') // ''; > > # -- op could be equal to >diff --git a/cataloguing/value_builder/unimarc_field_100.pl b/cataloguing/value_builder/unimarc_field_100.pl >index ad3c0549c6f..30e9038062f 100755 >--- a/cataloguing/value_builder/unimarc_field_100.pl >+++ b/cataloguing/value_builder/unimarc_field_100.pl >@@ -54,8 +54,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >- > my $defaultlanguage = C4::Context->preference("UNIMARCField100Language"); > $defaultlanguage = "fre" if ( !$defaultlanguage || length($defaultlanguage) != 3 ); > >diff --git a/cataloguing/value_builder/unimarc_field_100_authorities.pl b/cataloguing/value_builder/unimarc_field_100_authorities.pl >index c8fa9b42acb..95d39258224 100755 >--- a/cataloguing/value_builder/unimarc_field_100_authorities.pl >+++ b/cataloguing/value_builder/unimarc_field_100_authorities.pl >@@ -52,8 +52,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; >- > my $defaultlanguage = C4::Context->preference("UNIMARCField100Language"); > $defaultlanguage = "fre" if ( !$defaultlanguage || length($defaultlanguage) != 3 ); > >diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl >index 133da61f25f..a920fdd3989 100755 >--- a/cataloguing/value_builder/unimarc_field_105.pl >+++ b/cataloguing/value_builder/unimarc_field_105.pl >@@ -50,7 +50,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { > template_name => "cataloguing/value_builder/unimarc_field_105.tt", >diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl >index ce19338a855..ef0ea68c7a8 100755 >--- a/cataloguing/value_builder/unimarc_field_106.pl >+++ b/cataloguing/value_builder/unimarc_field_106.pl >@@ -48,7 +48,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result') || q{}; > >- my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { > template_name => "cataloguing/value_builder/unimarc_field_106.tt", >diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl >index 5ef09c18cba..e6c9f23940f 100755 >--- a/cataloguing/value_builder/unimarc_field_110.pl >+++ b/cataloguing/value_builder/unimarc_field_110.pl >@@ -50,7 +50,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { > template_name => "cataloguing/value_builder/unimarc_field_110.tt", >diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl >index 1249353a780..7d9b48b27ce 100755 >--- a/cataloguing/value_builder/unimarc_field_115a.pl >+++ b/cataloguing/value_builder/unimarc_field_115a.pl >@@ -55,7 +55,6 @@ sub plugin { > my $index = $input->param('index'); > my $result = $input->param('result'); > >- my $dbh = C4::Context->dbh; > my ( $template, $loggedinuser, $cookie ) = get_template_and_user( > { > template_name => "cataloguing/value_builder/unimarc_field_115a.tt", >diff --git a/opac/opac-search-history.pl b/opac/opac-search-history.pl >index b0a853b0dc2..831c819de44 100755 >--- a/opac/opac-search-history.pl >+++ b/opac/opac-search-history.pl >@@ -97,7 +97,6 @@ unless ($loggedinuser) { > } else { > > # And if the user is logged in, we deal with the database >- my $dbh = C4::Context->dbh; > > # Deleting search history > if ( $op eq 'cud-delete' ) { >-- >2.51.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41454
:
190535
|
190655