Bugzilla – Attachment 190579 Details for
Bug 41287
Using locale sorting may have a negative impact on search speeds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41287: (QA follow-up) Fix HTML syntax and improve logic consistency
1424778.patch (text/plain), 2.50 KB, created by
Martin Renvoize (ashimema)
on 2025-12-17 13:54:13 UTC
(
hide
)
Description:
Bug 41287: (QA follow-up) Fix HTML syntax and improve logic consistency
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-12-17 13:54:13 UTC
Size:
2.50 KB
patch
obsolete
>From 142477867cf3c6d208f4870c0ef050bf90ec1a8d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@openfifth.co.uk> >Date: Wed, 17 Dec 2025 13:52:11 +0000 >Subject: [PATCH] Bug 41287: (QA follow-up) Fix HTML syntax and improve logic > consistency > >This patch addresses two issues found in QA review: > >1. Fixed HTML syntax error in i18n_l10n.pref where closing anchor tag > was incorrectly written as <a> instead of </a> > >2. Changed C4/Search.pm to use elsif instead of separate if statement > for FacetOrder checking, matching the logic structure used in > Elasticsearch implementation and preventing potential double-execution > >Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> >--- > C4/Search.pm | 3 +-- > .../prog/en/modules/admin/preferences/i18n_l10n.pref | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/C4/Search.pm b/C4/Search.pm >index df3a0ab5923..de8162cb721 100644 >--- a/C4/Search.pm >+++ b/C4/Search.pm >@@ -592,8 +592,7 @@ sub getRecords { > if ($sorted_facets) { > $f->{facets} = $sorted_facets; > } >- } >- if ( C4::Context->preference('FacetOrder') eq 'Stringwise' ) { >+ } elsif ( C4::Context->preference('FacetOrder') eq 'Stringwise' ) { > @{ $f->{facets} } = sort { $a->{facet_label_value} cmp $b->{facet_label_value} } @{ $f->{facets} }; > } > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >index e629b8bf445..be78a5088a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref >@@ -67,7 +67,7 @@ I18N/L10N: > - Sort facet names using > - pref: FacetSortingLocale > type: locale-list >- - locale when <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=FacetOrder">FacetOrder<a> is set to alphabetically using locale. This enables proper Unicode-aware sorting of accented characters and locale-specific alphabetical ordering. >+ - locale when <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=FacetOrder">FacetOrder</a> is set to alphabetically using locale. This enables proper Unicode-aware sorting of accented characters and locale-specific alphabetical ordering. > - > - pref: TranslateNotices > choices: >-- >2.52.0 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41287
:
189898
|
190464
|
190465
|
190470
|
190472
|
190473
|
190577
|
190578
| 190579