Bugzilla – Attachment 190588 Details for
Bug 40771
Wrong transfer breaking check in for holds when using library transfer limits
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 40771: Fix transfer error when not auto filling hold
Bug-40771-Fix-transfer-error-when-not-auto-filling.patch (text/plain), 1.45 KB, created by
Nick Clemens (kidclamp)
on 2025-12-17 14:35:39 UTC
(
hide
)
Description:
Bug 40771: Fix transfer error when not auto filling hold
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-12-17 14:35:39 UTC
Size:
1.45 KB
patch
obsolete
>From 88db0c9ef389b5db13b7a306c57bd71580422733 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 17 Dec 2025 14:32:03 +0000 >Subject: [PATCH] Bug 40771: Fix transfer error when not auto filling hold > >This patch is another occurence where correcting a reserve transfer requires ignoring limits > >To test: >1 - Follow previous test plan >2 - Disable HoldsAutoFill >3 - Set library to Centerville >4 - Check the item in and confirm hold >5 - Set library to Fairfield >6 - Check the item in and confirm transfer >7 - Boom! Same error as before >8 - Apply this patch, restart all >9 - Check item in >10 - Correctly transferred to Centerville > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > circ/returns.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 5fa96697acf..488fd1f6be9 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -155,7 +155,8 @@ if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve' ) { > my $tobranch = $hold->pickup_library(); > > # Add transfer, enqueue if one is already in the queue, and immediately set to in transit >- my $transfer = $item->request_transfer( { to => $tobranch, reason => 'Reserve', enqueue => 1 } ); >+ my $transfer = >+ $item->request_transfer( { to => $tobranch, reason => 'Reserve', enqueue => 1, ignore_limits => 1 } ); > $transfer->transit; > } > } >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 40771
:
190585
|
190586
|
190587
| 190588