Bugzilla – Attachment 190589 Details for
Bug 41468
Dont force show checkin column if user hid it previously
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41468: Don't force show checkin column if user wants it hidden
Bug-41468-Dont-force-show-checkin-column-if-user-w.patch (text/plain), 1.87 KB, created by
Peter Vashchuk
on 2025-12-17 14:51:30 UTC
(
hide
)
Description:
Bug 41468: Don't force show checkin column if user wants it hidden
Filename:
MIME Type:
Creator:
Peter Vashchuk
Created:
2025-12-17 14:51:30 UTC
Size:
1.87 KB
patch
obsolete
>From ef60926390938db4e62baacaaabb4b2b08d27c29 Mon Sep 17 00:00:00 2001 >From: Petro Vashchuk <stalkernoid@gmail.com> >Date: Wed, 17 Dec 2025 16:50:49 +0200 >Subject: [PATCH] Bug 41468: Don't force show checkin column if user wants it > hidden > >If user hides the "Check in" column in the borrower's "Checkouts" table >it should stay hidden for the user unless in settings cannot_be_toggled >is set to true for the checkin column. > >Steps to reproduce: >1. Go to the borrower who have some checkouts, and open the checkout's table. >2. Check your admin/columns_settings, you can do that by using the top right Configure button. >Check that in issues-table, column checkin has "Cannot be toggled" toggled off. >3. Back at the borrower's page, using the Columns dropdown menu, hide "Check in" column. >4. Refresh the page. The column will be visible anyway. >5. Apply the patch. >6. Force refresh the page, and hide "Check in" column again. >7. Refresh the page. This time it should stay hidden. >8. Go back to admin/columns_settings and toggle on "Cannot be toggled" for checkin column. >9. Refresh borrower's page again, see that "Check in" column is visible again. >--- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 222b39a7811..00b1d2bb918 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -51,7 +51,10 @@ function LoadIssuesTable() { > checkin_column.is_hidden = 0; > } > renew_column.force_visibility = 1; >- checkin_column.force_visibility = 1; >+ >+ if (checkin_column.cannot_be_toggled) { >+ checkin_column.force_visibility = 1; >+ } > > let claims_returned_column = table_settings_issues_table.columns.find( > c => c.columnname == "claims_returned" >-- >2.51.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41468
: 190589