Bugzilla – Attachment 190592 Details for
Bug 41465
Unauthenticated request does not display 'type' correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41465: Fix display of 'type' for unauthenticated ILL request
Bug-41465-Fix-display-of-type-for-unauthenticated-.patch (text/plain), 2.17 KB, created by
OpenFifth Sandboxes
on 2025-12-17 17:03:29 UTC
(
hide
)
Description:
Bug 41465: Fix display of 'type' for unauthenticated ILL request
Filename:
MIME Type:
Creator:
OpenFifth Sandboxes
Created:
2025-12-17 17:03:29 UTC
Size:
2.17 KB
patch
obsolete
>From b2305cc6ac621223dc6111392e0bef7b517023b6 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@openfifth.co.uk> >Date: Wed, 17 Dec 2025 11:53:10 +0000 >Subject: [PATCH] Bug 41465: Fix display of 'type' for unauthenticated ILL > request > >'request' is unblessed in this context. get_type doesnt exist/work. > >Test plan: >1) Enable ILLModule and ILLOpacUnauthenticatedRequest >2) Logout, place an OPAC unauthenticated ILL request, visit: ><opac_url>/cgi-bin/koha/opac-illrequests.pl?backend=Standard&op=add_form >3) Input all mandatory fields. Click 'Create'. >4) Notice 'Request type' shows as 'N/A'. This will always be the case regardless of type you pick. >5) Apply patch. Repeat. Notice 'Request type' now shows as expected. > >Signed-off-by: Richard Bridgen <richard.bridgen@nhs.net> >--- > .../bootstrap/en/modules/opac-illrequests_unauthenticated.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests_unauthenticated.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests_unauthenticated.tt >index c64381e703..0a146987fd 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests_unauthenticated.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests_unauthenticated.tt >@@ -49,7 +49,6 @@ > <fieldset class="rows"> > <legend id="library_legend">Details from library</legend> > <ol> >- [% type = request.get_type %] > <li> > <label for="request_id">Request ID:</label> > [% request.illrequest_id | html %] >@@ -68,7 +67,7 @@ > </li> > <li> > <label for="medium">Request type:</label> >- [% IF type %][% type | html %][% ELSE %]<span>N/A</span>[% END %] >+ [% IF request.type %][% request.type | html %][% ELSE %]<span>N/A</span>[% END %] > </li> > <li> > <label for="placed">Request placed:</label> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41465
:
190569
|
190570
| 190592