Bugzilla – Attachment 190642 Details for
Bug 16131
Error messages for library transfers show with bullet points
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16131: Show branch transfer error messages in separate alert boxes
Bug-16131-Show-branch-transfer-error-messages-in-s.patch (text/plain), 6.39 KB, created by
Aleisha Amohia
on 2025-12-19 02:51:32 UTC
(
hide
)
Description:
Bug 16131: Show branch transfer error messages in separate alert boxes
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2025-12-19 02:51:32 UTC
Size:
6.39 KB
patch
obsolete
>From 6f8ef4d431b0738a134b561dc590760ab5f13f26 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleisha@catalyst.net.nz> >Date: Fri, 19 Dec 2025 02:43:11 +0000 >Subject: [PATCH] Bug 16131: Show branch transfer error messages in separate > alert boxes > >Currently error messages show in one alert box as bullet points. When there is only one error shown, this looks a bit strange to have a list with one item. This enhancement displays each error message as its own alert box. > >To test: > >1. Check out a Centerville item to someone in Centerville. For example, check out 39999000004175 to yourself. >2. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Centerville. >3. Confirm two error messages are shown, with one blue box for each. > >4. Go to Koha administration -> System preferences. Set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to collection code. >5. Go to Koha administration -> Library transfer limits. Go to the REF tab and uncheck the Allow transfer? box for FFL - Fairfield, then hit Save >6. Go to Circulation -> Transfers. Enter the barcode 39999000004175 and transfer the item to Fairfield. >7. Confirm the error message shows in a blue box with no bullet point. > >8. Type something random in the item barcode box and click Transfer. >9. Confirm the error message shows in a blue box with no bullet point. > >Sponsored-by: Catalyst IT >--- > .../prog/en/modules/circ/branchtransfers.tt | 71 ++++++++++--------- > 1 file changed, 36 insertions(+), 35 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >index 56dd9901695..c03e8ee439c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt >@@ -182,42 +182,43 @@ > [% END %] > > [% IF ( errmsgloop ) %] >- <div class="alert alert-info"> >- <ul> >- [% FOREACH errmsgloo IN errmsgloop %] >- [% IF ( errmsgloo.errbadcode ) %] >- <li>No item with barcode: [% errmsgloo.msg | html %]</li> >- [% END %] >- [% IF ( errmsgloo.errnotallowed ) %] >- <li >- >Transfer is not allowed for: >- <ol> >- [% IF ( Koha.Preference('BranchTransferLimitsType') == 'itemtype' ) %] >- <li>Item type: <strong>[% ItemTypes.GetDescription( errmsgloo.code ) | html %]</strong></li> >- [% ELSE %] >- <li>Collection: <strong>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => errmsgloo.code ) | html %]</strong></li> >- [% END %] >- <li>Originating library: <strong>[% Branches.GetName( errmsgloo.fbr ) | html %]</strong></li> >- <li>Destination library: <strong>[% Branches.GetName( errmsgloo.tbr ) | html %]</strong></li> >- </ol> >- </li> >- [% END %] >- [% IF ( errmsgloo.errdesteqholding ) %] >- <li>Item is already at destination library.</li> >- [% END %] >- [% IF ( errmsgloo.errwasreturned ) %] >- <li >- >Item was on loan to >- <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% errmsgloo.patron.borrowernumber | uri %]"> >- [% errmsgloo.patron.firstname | html %] [% errmsgloo.patron.surname | html %] ([% errmsgloo.patron.cardnumber | html %])</a >- > >- and has been returned.</li >+ [% FOREACH errmsgloo IN errmsgloop %] >+ [% IF ( errmsgloo.errbadcode ) %] >+ <div class="alert alert-info"> >+ <p>No item with barcode: [% errmsgloo.msg | html %]</p> >+ </div> >+ [% END %] >+ [% IF ( errmsgloo.errnotallowed ) %] >+ <div class="alert alert-info"> >+ <p>Transfer is not allowed for:</p> >+ <ol> >+ [% IF ( Koha.Preference('BranchTransferLimitsType') == 'itemtype' ) %] >+ <li>Item type: <strong>[% ItemTypes.GetDescription( errmsgloo.code ) | html %]</strong></li> >+ [% ELSE %] >+ <li>Collection: <strong>[% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => errmsgloo.code ) | html %]</strong></li> >+ [% END %] >+ <li>Originating library: <strong>[% Branches.GetName( errmsgloo.fbr ) | html %]</strong></li> >+ <li>Destination library: <strong>[% Branches.GetName( errmsgloo.tbr ) | html %]</strong></li> >+ </ol> >+ </div> >+ [% END %] >+ [% IF ( errmsgloo.errdesteqholding ) %] >+ <div class="alert alert-info"> >+ <p>Item is already at destination library.</p> >+ </div> >+ [% END %] >+ [% IF ( errmsgloo.errwasreturned ) %] >+ <div class="alert alert-info"> >+ <p >+ >Item was on loan to >+ <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% errmsgloo.patron.borrowernumber | uri %]" >+ >[% errmsgloo.patron.firstname | html %] [% errmsgloo.patron.surname | html %] ([% errmsgloo.patron.cardnumber | html %])</a > > >- [% END %] >- [% END # /FOREACH errmsgloo %] >- </ul> >- </div> >- <!-- /.dialog.message --> >+ and has been returned.</p >+ > >+ </div> >+ [% END %] >+ [% END # /FOREACH errmsgloo %] > [% END # /errmsgloop %] > > <div id="branchtransfers"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16131
:
49422
|
49427
|
190642
|
190645
|
190684