Bugzilla – Attachment 190678 Details for
Bug 41395
Terminology: Target item cannot be reserved from other branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41395: Terminology: Target item cannot be reserved from other branches
Bug-41395-Terminology-Target-item-cannot-be-reserv.patch (text/plain), 3.34 KB, created by
Laura Escamilla
on 2025-12-22 14:36:43 UTC
(
hide
)
Description:
Bug 41395: Terminology: Target item cannot be reserved from other branches
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2025-12-22 14:36:43 UTC
Size:
3.34 KB
patch
obsolete
>From b81870fbaf60bafd13cc1107e875f4f99c5dfd7a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 17 Dec 2025 08:35:41 -0500 >Subject: [PATCH] Bug 41395: Terminology: Target item cannot be reserved from > other branches >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Testing Steps >1. Set the system preference CanReserveFromOtherBranches to âDonât allow.â >2. Enable the system preference IndependentBranches. >3. Place a hold on an item from your local branch. >4. View the existing hold and select it. >5. Click âMove selectedâ, then choose âRecord level holds to a different record.â > * For testing, the original hold was placed on biblionumber 10 (Centerville item). > * The hold was then moved to biblionumber 41 (Fairview item), which should not allow holds from another branch. >6. Observe the error message:â¨âHold ID: 4 Target item cannot be reserved from other branches.â⨠>7. Apply the patch and refresh the page. >8. Observe the updated error message:â¨âHold ID: 4 Target item cannot be placed on hold from other libraries.â⨠> >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 27163722b3..e5877e7089 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -206,7 +206,7 @@ > <span>[% fail.hold_id | html %]</span> > [% SWITCH fail.error %] > [% CASE 'cannotReserveFromOtherBranches' %] >- <span>Target item cannot be reserved from other branches</span> >+ <span>Target item cannot be placed on hold from other libraries</span> > [% CASE 'ageRestricted' %] > <span>The target record and/or items are age restricted</span> > [% CASE 'alreadypossession' %] >@@ -219,8 +219,6 @@ > <span>Target item has too many holds placed on it</span> > [% CASE 'notReservable' %] > <span>Target item is not reservable</span> >- [% CASE 'cannotReserveFromOtherBranches' %] >- <span>Target item cannot be placed on reserve for this branch</span> > [% CASE 'branchNotInHoldGroup' %] > <span>Tagret item is not in the local hold group</span> > [% CASE 'notforloan' %] >@@ -1607,7 +1605,7 @@ > tooManyReservesToday: _("Daily hold limit reached for patron"), > tooManyReserves: _("Too many holds"), > notReservable: _("Not holdable"), >- noReservesAllowed: _("No reserves allowed"), >+ noReservesAllowed: _("No holds allowed"), > cannotReserveFromOtherBranches: _("Patron is from different library"), > itemAlreadyOnHold: _("Patron already has hold for this item"), > cannotBeTransferred: _("Cannot be transferred to pickup library"), >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41395
:
190617
|
190644
| 190678