Bugzilla – Attachment 190765 Details for
Bug 41431
Circulation rule notes dropping when editing rule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41431: Use correct data-attribute to fetch existing circulation rule note
Bug-41431-Use-correct-data-attribute-to-fetch-exis.patch (text/plain), 1.98 KB, created by
David Nind
on 2025-12-29 17:33:45 UTC
(
hide
)
Description:
Bug 41431: Use correct data-attribute to fetch existing circulation rule note
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-12-29 17:33:45 UTC
Size:
1.98 KB
patch
obsolete
>From 5c7e5f96d726a48a43b7df5add504603e2fb755a Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Mon, 29 Dec 2025 11:13:08 +0200 >Subject: [PATCH] Bug 41431: Use correct data-attribute to fetch existing > circulation rule note > >If you click Edit on a line with a note, the note field is not displayed >in the editing line and is blanked upon save (i.e., the note is lost, >even if you made no edits on the note). Value of the note is stored to >data-attribute which was changed to use Bootstraps own data-attribute. >So now the value must be fetched with keyword "bsContent" instead of >just "content". > >To test: >1. Add note for a circulation rule. >2. Edit the rule. >=> Note that notes value is not displayed in editing row. >3. Apply this patch. >4. Edit rule again. >=> Note that notes value is now displayed as expected. > >Sponsored-by: Koha-Suomi Oy >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >index bd0526017d..f186f2d62f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt >@@ -1542,7 +1542,7 @@ > var current_input_id = $(current_column).children("input").first().attr("id"); > if (current_input_id === "note") { > // specific processing for the Note column >- var note = $(this).find("a[id='viewnote']").data("content"); >+ var note = $(this).find("a[id='viewnote']").data("bsContent"); > $(current_column).find("input[type='text']").val(note); > } else if (current_input_id === "hardduedate") { > // specific processing for Hard due date >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41431
:
190754
|
190765
|
192618