Bugzilla – Attachment 190804 Details for
Bug 37569
Serials without history cannot be edited
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37569: Fix the way serials are returned
Bug-37569-Fix-the-way-serials-are-returned.patch (text/plain), 1.69 KB, created by
David Nind
on 2025-12-31 18:18:30 UTC
(
hide
)
Description:
Bug 37569: Fix the way serials are returned
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-12-31 18:18:30 UTC
Size:
1.69 KB
patch
obsolete
>From 17026d9dd4853b26ac17bc0e61f6fcc4f4692c51 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <bski@laposte.net> >Date: Mon, 5 Aug 2024 15:24:51 +0200 >Subject: [PATCH] Bug 37569: Fix the way serials are returned > >Serials cannot be edited if there is no history associated to the serial. Fetching a subscription matching a given serialnumber results in an hashref containing two fields named serial number. One of them is undef and is used by the form and is therefore not submitted at the end. > >This is not supposed to happen since creating an exemplary automatically creates a new exemplary, but if serials are created through DB, they are not editable. > >Test plan: >1 - Create a serial >2 - In the database remove there history associated with the serial >3 - Try and edit serial, at the end of the form, it will result in > "serial not found" >4 - Apply patch >5 - Redo 3 and notice it now works > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Serials.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index 918f84d6bb..377f71dcb0 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -276,7 +276,8 @@ sub GetSubscription { > aqbooksellers.name AS aqbooksellername, > biblio.title AS bibliotitle, > biblio.subtitle AS bibliosubtitle, >- subscription.biblionumber as bibnum >+ subscription.biblionumber as bibnum, >+ subscription.subscriptionid as subscriptionid > FROM subscription > LEFT JOIN subscriptionhistory ON subscription.subscriptionid=subscriptionhistory.subscriptionid > LEFT JOIN aqbooksellers ON subscription.aqbooksellerid=aqbooksellers.id >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37569
:
170062
|
190757
| 190804