Bugzilla – Attachment 190950 Details for
Bug 41315
Using patron-homelibrary option for overdue notices may not send notices to all branches
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41315: Remove unecessary conditional
Bug-41315-Remove-unecessary-conditional.patch (text/plain), 1.59 KB, created by
Andrew Fuerste-Henry
on 2026-01-06 19:12:55 UTC
(
hide
)
Description:
Bug 41315: Remove unecessary conditional
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2026-01-06 19:12:55 UTC
Size:
1.59 KB
patch
obsolete
>From f3aff008f2815abcfc612340241c7a16682b04f5 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 26 Nov 2025 16:06:26 +0000 >Subject: [PATCH] Bug 41315: Remove unecessary conditional > >We are in a loop here: >foreach my $branchcode (@branches) { > >branchcode must be defined or something has gone seriously wrong with PERL > >Signed-off-by: Ben Daeuber <bdaeuber@fargolibrary.org> >--- > misc/cronjobs/overdue_notices.pl | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl >index 7962a2b2525..86ef302b750 100755 >--- a/misc/cronjobs/overdue_notices.pl >+++ b/misc/cronjobs/overdue_notices.pl >@@ -575,14 +575,14 @@ AND items.itemlost = 0 > AND TO_DAYS($date)-TO_DAYS(issues.date_due) >= 0 > END_SQL > my @borrower_parameters; >- if ($branchcode) { >- if ($owning_library) { >- $borrower_sql .= ' AND items.homebranch=? '; >- } else { >- $borrower_sql .= ' AND issues.branchcode=? '; >- } >- push @borrower_parameters, $branchcode; >+ >+ if ($owning_library) { >+ $borrower_sql .= ' AND items.homebranch=? '; >+ } else { >+ $borrower_sql .= ' AND issues.branchcode=? '; > } >+ push @borrower_parameters, $branchcode; >+ > if ( $overdue_rules->{categorycode} ) { > $borrower_sql .= ' AND borrowers.categorycode=? '; > push @borrower_parameters, $overdue_rules->{categorycode}; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41315
:
189965
|
189966
|
189967
|
189968
|
190949
| 190950 |
190951
|
190952