Bugzilla – Attachment 191014 Details for
Bug 39014
Storing a guarantee fails due to TrackLastPatronActivityTriggers "creating a patron"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39014: Remove unnecessary tests
Bug-39014-Remove-unnecessary-tests.patch (text/plain), 2.79 KB, created by
Lucas Gass (lukeg)
on 2026-01-07 20:38:47 UTC
(
hide
)
Description:
Bug 39014: Remove unnecessary tests
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2026-01-07 20:38:47 UTC
Size:
2.79 KB
patch
obsolete
>From 7c04f87b99d3a02845fa4fd29d2100e17565f070 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 7 Jan 2026 20:38:15 +0000 >Subject: [PATCH] Bug 39014: Remove unnecessary tests > >--- > t/db_dependent/Circulation.t | 43 +----------------------------------- > 1 file changed, 1 insertion(+), 42 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index af0a61c5324..31f171cbbe2 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -7667,7 +7667,7 @@ subtest 'NoRefundOnLostFinesPaidAge' => sub { > }; > > subtest 'ChildNeedsGuarantor' => sub { >- plan tests => 18; >+ plan tests => 12; > > t::lib::Mocks::mock_preference( 'ChildNeedsGuarantor', 0 ); > my $library = $builder->build_object( { class => 'Koha::Libraries' } ); >@@ -7745,47 +7745,6 @@ subtest 'ChildNeedsGuarantor' => sub { > library => $library->branchcode, > } > ); >- warnings_like { >- AddIssue( $child_patron, $item->barcode, undef ); >- } >- qr/Problem updating lastseen/, >- "AddIssue generates a warning when Child type patron is missing a guarantor and ChildsNeedsGuarantor"; >- warnings_like { >- AddRenewal( >- { >- borrowernumber => $child_patron->borrowernumber, itemnumber => $item->itemnumber, >- branch => $library->branchcode >- } >- ); >- } >- qr/Problem updating lastseen/, >- "AddRenewal generates a warning when Child type patron is missing a guarantor and ChildNeedsGuarantor"; >- warnings_like { >- AddReturn( $item->barcode, $library->branchcode, undef, undef ); >- } >- qr/Problem updating lastseen/, >- "AddReturn generates a warning when Child type patron is missing a guarantor and ChildNeedsGuarantor"; >- >- warnings_like { >- AddIssue( $guarantee_patron, $item->barcode, undef ); >- } >- qr/Problem updating lastseen/, >- "AddIssue generates a warning when can_be_guarantee type patron is missing a guarantor and ChildsNeedsGuarantor"; >- warnings_like { >- AddRenewal( >- { >- borrowernumber => $guarantee_patron->borrowernumber, itemnumber => $item->itemnumber, >- branch => $library->branchcode >- } >- ); >- } >- qr/Problem updating lastseen/, >- "AddRenewal generates a warning when can_be_guarantee type patron is missing a guarantor and ChildNeedsGuarantor"; >- warnings_like { >- AddReturn( $item->barcode, $library->branchcode, undef, undef ); >- } >- qr/Problem updating lastseen/, >- "AddReturn generates a warning when can_be_guarantee type patron is missing a guarantor and ChildNeedsGuarantor"; > > t::lib::Mocks::mock_preference( 'ChildNeedsGuarantor', 0 ); > warnings_like { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39014
:
177563
|
177564
|
177619
|
178546
|
178547
|
179572
|
180298
|
182290
|
188041
|
188461
|
188462
|
188463
|
188464
|
190493
|
190494
|
190767
|
190768
|
190769
|
190770
|
190772
|
190773
| 191014