Bugzilla – Attachment 191038 Details for
Bug 41545
JS warning "redeclaration of let filters_options"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 41545: Remove JS warning "redeclaration of let filters_options"
ca5153f.patch (text/plain), 1.25 KB, created by
David Nind
on 2026-01-08 23:37:06 UTC
(
hide
)
Description:
Bug 41545: Remove JS warning "redeclaration of let filters_options"
Filename:
MIME Type:
Creator:
David Nind
Created:
2026-01-08 23:37:06 UTC
Size:
1.25 KB
patch
obsolete
>From ca5153f6868aa122ef36cd2a028b4ca45d4c57dc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 8 Jan 2026 15:06:56 +0100 >Subject: [PATCH] Bug 41545: Remove JS warning "redeclaration of let > filters_options" > >On the suggestions page more than one patron search is injected into the >page that leads to JS warnings when the JS variable is defined with >"let". We should use "var" in this case. > >Test plan: >/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL >And notice that the warning does no longer appear when this patch is >applied. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index d83f219dac..817a76c08c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -275,7 +275,7 @@ > return map; > }, {}); > >- let filters_options = { >+ var filters_options = { > libraries, > categories, > av_bsort1, >-- >2.39.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 41545
:
191026
| 191038